Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Url is imported but its value is never used #38

Closed
KamasamaK opened this issue Apr 8, 2020 · 3 comments · Fixed by #39
Closed

Url is imported but its value is never used #38

KamasamaK opened this issue Apr 8, 2020 · 3 comments · Fixed by #39
Assignees
@gr2m
Labels
Type: Bug Something isn't working as documented, or is being fixed

Comments

@KamasamaK
Copy link

The imported Url at

types.ts/src/generated/Endpoints.ts

Line 4 in 6dd3451

import { Url } from "../Url";

is unused.
@KamasamaK KamasamaK added the Type: Bug Something isn't working as documented, or is being fixed label Apr 8, 2020
@gr2m
Copy link
Contributor

gr2m commented Apr 8, 2020

Hm I thought I got that fixed in #36, but turnes out I only fixed it in the template, not in the generated file, sorry for that!

@gr2m gr2m self-assigned this Apr 8, 2020
@gr2m gr2m mentioned this issue Apr 8, 2020
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2020

🎉 This issue has been resolved in version 2.8.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Contributor

gr2m commented Apr 8, 2020

that should be fixed in https://github.com/octokit/types.ts/releases/tag/v2.8.0

@gr2m gr2m closed this as completed Apr 8, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@gr2m gr2m

Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unused imports octokit/types.ts
2 participants
@gr2m @KamasamaK