Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fits image visualisation? #288

Closed
andriineronov opened this issue Jan 7, 2025 · 9 comments · Fixed by #289
Closed

fits image visualisation? #288

andriineronov opened this issue Jan 7, 2025 · 9 comments · Fixed by #289
Assignees

Comments

@andriineronov
Copy link

What is the status of visualizers developed by Francois? I see that "fits image" data product is visualised with Bokeh.... it looks ugly, with x and y axis in "pixel number"..... Before it was possible to visualise it with JS9, but this si gone...... would be better to have Aladin Lite for the visualisation, is this not available? Just in case, I was working on MAGIC and LST services.

@dsavchenko
Copy link
Member

Hi
We never had neither Aladin nor table visualisation lib integrated in MMODA. This requires frontend development with a different approach (currently, visualisations are generated by dispatcher and embedded in the page). I don't know well the approach of js9 though.

Normally, JS9 visualisation should be available for images, we didn't remove it. Need to explore why frontend doesn't recognise product as a sky image

@dsavchenko
Copy link
Member

@burnout87 may also have insights

@volodymyrss
Copy link
Member

If its gone, the change that removed compromised helper is responsible. Then we should restore it and patch ad suggested. @dsavchenko could you please help?

for aladin, is there any difficulty to make dispatcher generate page with aladin? @dsavchenko @burnout87 ? Then its a small change, no refactoring.

@dsavchenko
Copy link
Member

JS9 is not deactivated. It works with ISGRI for example.
In MAGIC however, it's not active. Maybe because this button is in the first window. But here we have a list, not a single image.

See attached screenshots.

image
image
image

This requires JS changes in frontend I guess, the logic there is a bit convoluted

@burnout87
Copy link
Collaborator

burnout87 commented Jan 7, 2025

I confirm what @dsavchenko said.

The JS9 button is not available for the case @andriineronov is working on, because of the logic implemented in the frontend. However it should be quite easy to extend the logic also to the case here described, I will work on it

@burnout87 burnout87 linked a pull request Jan 7, 2025 that will close this issue
@volodymyrss
Copy link
Member

Oh good. Just to keep track of the mentioned point, would it really be difficult to generate a page with aladinlite from dispatcher?

@burnout87
Copy link
Collaborator

Oh good. Just to keep track of the mentioned point, would it really be difficult to generate a page with aladinlite from dispatcher?

And replace JS9 and/or bokeh? it would need an implementation of a similar function inside the plot_tool of the dispatcher, but I dont have experience (yet) with Aladin

@volodymyrss
Copy link
Member

volodymyrss commented Jan 7, 2025

Oh good. Just to keep track of the mentioned point, would it really be difficult to generate a page with aladinlite from dispatcher?

And replace JS9 and/or bokeh? it would need an implementation of a similar function inside the plot_tool of the dispatcher, but I dont have experience (yet) with Aladin

If it's not currently urgent, maybe it's for a bit later. But very soon it would be desirable.

I think it's not complex, easier than JS9. You can ask @francoismg for advice.

edit: ultimately to replace both bokeh (for images) and js9. both js9 and bokeh are not ideal, at the moment for sure.

@dsavchenko
Copy link
Member

From what I understand, with aladin, one can't do as with bokeh, generating the visualisation server-side.

The file needs to be served by url. Looks like js9 now uses this approach, at least I see that temporary file js9.fits is created in a session dir and then served via api/v1.0/oda/product/<path> directly from there. For me, it's unclear, why we ever need this temporary file as long as the actual product file is also directly servable.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants