You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have being running into a dropped missing unique "key" prop issue with Immutable.Record instances as they are boxed, I have posted a comment in the relevant change: 6d8b850#commitcomment-10791363
I there a reason why Immutable instances are also boxed and not just cursors ?
Also regardless of type of the structure that omniscient boxes it should probably use a key from that structure otherwise it is impossible to render data structure of that type with a key.
The text was updated successfully, but these errors were encountered:
Immutable instances are boxed to unwrap them as arguments when passed to the render-function but still work as expected inside the shouldComponentUpdate.
You may have a point about using the key from the structure which is passed. For now it only checks the argument key or props.key. If we were to extend this, we would have to do some "precedence checking". What if argument key is set, and we have this:
But in this way we are starting to more and more couple to the Immutable.js implementation. _isCursor and _isImmutable are overridables, but inputCursor.get('key') would be implementation specific.
I have being running into a dropped missing unique "key" prop issue with
Immutable.Record
instances as they are boxed, I have posted a comment in the relevant change:6d8b850#commitcomment-10791363
I there a reason why Immutable instances are also boxed and not just cursors ?
Also regardless of type of the structure that omniscient boxes it should probably use a key from that structure otherwise it is impossible to render data structure of that type with a key.
The text was updated successfully, but these errors were encountered: