You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, calling OmegaConf.to_container(cfg) can result in a python object that contains some "???" MISSING strings.
I propose to add a throw_on_missing keyword argument to OmegaConf.to_container, so that the structure returned by OmegaConf.to_container(cfg, throw_on_missing=True) will raise omegaconf.MissingMandatoryValue if any missing values are encountered.
This way, if no MissingMandatorValue is raised, clients can be assured that the result of to_container does not contain any "???" strings.
To maintain backward compatibility, the default would be throw_on_missing=False.
The text was updated successfully, but these errors were encountered:
Feature:
Currently, calling
OmegaConf.to_container(cfg)
can result in a python object that contains some"???"
MISSING strings.I propose to add a
throw_on_missing
keyword argument toOmegaConf.to_container
, so that the structure returned byOmegaConf.to_container(cfg, throw_on_missing=True)
will raiseomegaconf.MissingMandatoryValue
if any missing values are encountered.This way, if no
MissingMandatorValue
is raised, clients can be assured that the result ofto_container
does not contain any"???"
strings.To maintain backward compatibility, the default would be
throw_on_missing=False
.The text was updated successfully, but these errors were encountered: