Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change the default value of OmegaConf.update merge flag to True #667

Closed
omry opened this issue Apr 7, 2021 · 0 comments · Fixed by #670
Closed

Change the default value of OmegaConf.update merge flag to True #667

omry opened this issue Apr 7, 2021 · 0 comments · Fixed by #670
Labels
maintenance
Milestone
OmegaConf 2.1

Comments

@omry
Copy link
Owner

omry commented Apr 7, 2021

The merge flag was added in OmegaConf 2.0.2 with the intention of making it default to True.
to avoid a breaking change, a warning was issued for people that used update and did not specify a value for the merge flag.

It's time to clean this up.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
OmegaConf 2.1
Development

Successfully merging a pull request may close this issue.

OmegaConf.update merge flag is now True by default omry/omegaconf
1 participant
@omry