Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PackageInfo: Invalid constraint (PyYAML (>=5.1.*)) found in omegaconf-2.1.0 dependencies, skipping #758

Closed
3 of 4 tasks
gygabyte017 opened this issue Jun 23, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@gygabyte017
Copy link

Describe the bug
When installing omegaconf with poetry command poetry add omegaconf, the follogin warning is issued:

PackageInfo: Invalid constraint (PyYAML (>=5.1.*)) found in omegaconf-2.1.0 dependencies, skipping

To Reproduce
Just install the package in an empty environment.

Expected behavior
To correctly get and install the pyyaml dependency.

Additional context

  • OmegaConf version: 2.1.0
  • Python version: 3.8
  • Operating system: Windows
  • Please provide a minimal repro
@gygabyte017 gygabyte017 added the bug Something isn't working label Jun 23, 2021
@omry
Copy link
Owner

omry commented Jun 24, 2021

Why is this an invalid constraint? pip likes it just fine.

@gygabyte017
Copy link
Author

I'm not sure it is invalid, if with pip is ok I'll open an issue in poetry repo about it and let you know.

@omry
Copy link
Owner

omry commented Jun 24, 2021

I didn't hear or see any reports about it causing issues for anyone else.
This seems in line with https://www.python.org/dev/peps/pep-0440/

e.g: https://www.python.org/dev/peps/pep-0440/#version-matching

@gygabyte017
Copy link
Author

They say >=5.1.* is not a valid PEP440. (Issue: python-poetry/poetry#4206 and linked issues)

In fact reading PEP440 I see that the * is accepted only with == or with != and not with >=; moreover ==5.1.* is equivalent to >=5.1.0 but >=5.1.* is invalid.

What do you think?

@omry
Copy link
Owner

omry commented Jun 25, 2021

Thanks. Sounds fine.
Go ahead and send a PR fixing it to >=5.1 or >=5.1.0.
(Alternatively, you can wait for us to get to it).

@omry omry added this to the OmegaConf 2.1.1 milestone Jun 25, 2021
@gygabyte017
Copy link
Author

Opened PR #761

@ZetiMente
Copy link

@omry Hi, I just started using OmegaConf and ran into this error. It appears to be fixed now. PR #761. Is there any chance of a new release soon? I'm very excited to be using OmegaConf because it's making my newest ML project awesome. However, this error prevents it from working in Google Colab.

@omry
Copy link
Owner

omry commented Aug 12, 2021

@Jasha10, do you want to try to release 2.1.1 with this fix?

@Jasha10
Copy link
Collaborator

Jasha10 commented Aug 12, 2021

Sure, I'll give it a try!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants