Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redirects on well-known endpoint (FI-1659) #180

Closed
arscan opened this issue Jul 25, 2022 · 4 comments
Closed

Redirects on well-known endpoint (FI-1659) #180

arscan opened this issue Jul 25, 2022 · 4 comments
Labels
g10-test-kit This issue affects onc-certification-g10-test-kit remove constraint The change should not cause a system that previously passed to now fail. v2.3.0 Release v2.3.0

Comments

@arscan
Copy link
Contributor

arscan commented Jul 25, 2022

A (g)(10) impacting issue was raised here: inferno-framework/inferno-core#229

We utilize redirects to manage multiple connections through a single gateway. For example:
https://www.medentfhirtest.com/fhir/R4/savcw237/.well-known/smart-configuration
redirects to
https://www.medentfhirtest.com/fhir/R4/.well-known/smart-configuration/index.php?medent_practice_id=savcw237

This worked for the previous Inferno test suites, but is now returning a 302 on the very first test.

Will redirects like this be supported or do we need to reconfigure our connections?

Thanks!
Savannah Dearing

@arscan arscan added remove constraint The change should not cause a system that previously passed to now fail. will fix Issue is planned to be addressed in future release g10-test-kit This issue affects onc-certification-g10-test-kit labels Jul 25, 2022
@SavannahDearing
Copy link

I know its only been a week, but just checking in on this so we can continue testing :)

@arscan
Copy link
Contributor Author

arscan commented Aug 1, 2022

Hi @SavannahDearing -- the http client used in the discovery tests will follow the redirects automatically in the next release, out next week.

I have a feeling this might trip up some clients out there, as it tripped us up when we switched to a new http client in v2.0 of our tests. But following redirects automatically should be a configuration option for most http libraries out there, and language in the referenced specs are vague about this, so it makes sense for us to just allow servers to do this if they'd like.

@SavannahDearing
Copy link

Thanks for following up, we also found the specs were a bit vague on it. In general, with other interfacing we've been able to use redirects as long as its not a new domain name.

@yunwwang yunwwang added resolved Fix is approved and merged. Working ticket closed v2.3.0 Release v2.3.0 and removed will fix Issue is planned to be addressed in future release resolved Fix is approved and merged. Working ticket closed labels Aug 9, 2022
@yunwwang yunwwang changed the title Redirects on well-known endpoint Redirects on well-known endpoint (FI-1659) Aug 9, 2022
@yunwwang
Copy link
Contributor

yunwwang commented Aug 9, 2022

Pull Request: inferno-framework/inferno-core#231

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
g10-test-kit This issue affects onc-certification-g10-test-kit remove constraint The change should not cause a system that previously passed to now fail. v2.3.0 Release v2.3.0
Projects
None yet
Development

No branches or pull requests

3 participants