fix: should set User-Agent in axios for Firefox

one-zero-eight · Jun 21, 2024 · 6699bd8 · 6699bd8
1 parent 4b4efa7
commit 6699bd8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/entrypoints/background/net-rules.ts b/src/entrypoints/background/net-rules.ts
@@ -5,7 +5,8 @@ import Rule = chrome.declarativeNetRequest.Rule
 import RuleActionType = chrome.declarativeNetRequest.RuleActionType
 
 export async function applyUserAgentRule() {
-  // Set "MoodleMobile" User-Agent for requests to get_autologin_key
+  // Set "MoodleMobile" User-Agent for requests to get_autologin_key.
+  // This doesn't work in Firefox, so we need to set User-Agent in Axios.
   const ua_rule: Rule = {
     id: 1,
     action: {

diff --git a/src/shared/moodle-ws-api/axios.ts b/src/shared/moodle-ws-api/axios.ts
@@ -9,9 +9,9 @@ export const AxiosWS = axios.create({
   method: 'POST',
   headers: {
     'Content-Type': 'application/x-www-form-urlencoded',
-    // Browser doesn't allow to set User-Agent here.
-    // Extension should use declarativeNetRequest rules.
-    // "User-Agent": "MoodleMobile",
+    // Chrome prohibits to set User-Agent here. We should use declarativeNetRequest rules.
+    // But Firefox allows to set User-Agent here.
+    'User-Agent': 'MoodleMobile',
   },
 })