Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix for issue where if there were multiple signing certs and no encry… #65

Merged
merged 3 commits into from
Sep 14, 2017

Conversation

bmorgan21
Copy link
Contributor

…ption certs, only the first signing cert is returned

…ption certs, only the first signing cert is returned
@pitbulk
Copy link
Contributor

pitbulk commented Sep 7, 2017

Can you provide test so we assure we don't break in the future?

@bmorgan21
Copy link
Contributor Author

yes, just figuring out the environment. Once the tests pass, I will update the tests.

@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage increased (+0.9%) to 95.615% when pulling 49574c3 on bmorgan21:master into 16cd67c on onelogin:master.

@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage increased (+0.9%) to 95.615% when pulling 3d35b5c on bmorgan21:master into 16cd67c on onelogin:master.

@bmorgan21
Copy link
Contributor Author

@pitbulk this PR should be ready for you to take a look!

@bmorgan21
Copy link
Contributor Author

Anything else needed here to get this merged and to make a patch release?

@pitbulk pitbulk merged commit 141798f into SAML-Toolkits:master Sep 14, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants