RGS: bank account not to be created automatically when creating banks

[astirpe]

When creating account journals of type == Bank, the Bank Account must be not created automatically. The Bank Account has to be selected from existing RGS accounts.

[astirpe]

Done in d575029

[astirpe]

Loading demo data fixed in 44750ae

[astirpe]

Proposal for improving usability:

• create a new module l10n_nl_rgs_usability
• add dependency to l10n_nl_rgs and base_view_inheritance_extension
• in form view of account.journal, on field default_account_id pass context {"domain_account_journal_type": object.type}
• in account.account add method def name_search() so that, in case domain_account_journal_type is defined, the standard domain is extended with: args = [("code", "=ilike", company.bank_account_code_prefix + "%")] + args

[astirpe]

Module for usability improvements added with dfa1c0b

[astirpe]

Same issue applies to account journals of type == Cash, this case is also fixed in a356e06

[andreschenkels]

@astirpe was this seen as an issue because I talked about this with Joery and you just need to create the bacnk account numbers at the correct place in the schema and add a reference code.

[astirpe]

@andreschenkels

Odoo automatically creates accounts for banks when the user is creating a new bank journal. This is an issue because the the newly created account would be not from the RGS schema, which already contains a set of predefined accounts for banks.

With this fix, the user is forced to select an existing bank account from RGS schema.

Let me know if you need extra clarifications.

[andreschenkels]

@astirpe I know there are some accounts defined in the RGS. But you could easily create accounts on the same place in the RGS schema. You're solution is valid. But maybe less user friendly.

[astirpe]

This solution is actually what it came out from the discussion with Joery last friday. But I agree with you that it could be made more user friendly by making it smarter.

[astirpe]

With PR #17 the bank account is automatically selected in case there is any bank account available. It's a small usability improvement.

The logic of creating new bank accounts is not yet implemented, but maybe it could be easily achieved by adding extra bank accounts directly in the csv file, as Joury explained during the last meeting.

[astirpe]

As a reminder for me, set the bank account to active (not deprecated) after the creation of the bank.

Edited: done in 6288b1e

[ThijsvOers]

@astirpe When duplicating a bank journal the correct settings are now applied (new account, new reference code, correct default settings for short code and sequence). Is there someting else to be done?

[astirpe]

@ThijsvOers I think this issue can be closed, since it was tested multiple times. If needed we could reopen it later on.