-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Exception handlers cause warnings when exceptions are disabled #44
Comments
…_CATCH_IN_ASSERTS config identifiers fixes #44
try the dev branch and let me know if everything works fine - also checkout these docs in the dev branch U'll have to define |
@onqtam Works as expected! |
…ons even without exceptions - see the use of DOCTEST_CONFIG_NO_EXCEPTIONS_BUT_WITH_ALL_ASSERTS - added clang 3.9 to build matrix relates #44
…o see this commit: google/googletest@3498a1a relates #44
C++ exceptions in my opinion (and in the opinion of others) are subpar and I usually have them turned off along with RTTI. However,
the presence of try/catch blocks in doctest causes warnings (at least on MSVC - C4530) which can't be suppressed (and I'm building with /W4 /WX so this breaks my build).
I simply deleted / commented out all usages of try/catch in the my copy of the library but it will be helpful to only use exceptions handling if the user's exceptions are enabled. This can be detected by checking for
__cpp_exceptions
on gcc_HAS_EXCEPTIONS
on MSVCThe text was updated successfully, but these errors were encountered: