chore: update comments for named provider related function #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beeme1mr, @Kavindu-Dodan PTAL, thanks! |
beeme1mr
approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 10 10
Lines 1203 1203
=======================================
Hits 946 946
Misses 230 230
Partials 27 27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @yongruilin! Could you please sign off your commits? It's a requirement from the CNCF before we can merge. |
Signed-off-by: yongruilin <yongrlin@outlook.com>
yongruilin
force-pushed
the
provider-comment
branch
from
67ccfb7 to
a01f7f2
Compare
|
It looks like there's an unrelated build error. I'll look into it tomorrow. |
I guess it is the same problem identified by @Kavindu-Dodan in the contrib repo: https://github.com/open-feature/go-sdk-contrib/pull/317/files#r1306174491 |
|
I've opened #216 to fix the ci issue. |
toddbaert
approved these changes
Sep 6, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Update comments for named provider related functions.
Related Issues
N/A
Notes
Only updates comments.
Follow-up Tasks
N/A
How to test
N/A