Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: sort imports of go files #214

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

yongruilin
Copy link
Contributor

This PR

Sorts imports of go files by running command on root directory.

~/go-sdk goimports -w .

Related Issues

N/A

Notes

In VSCode settings.json

   ...
    "[go]": {
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true
        },
    },
   ...

Also results in it sorts the imports every time onSave.

Follow-up Tasks

Probably we can setup pre-merge check or pre-commit for go format and lint.

How to test

N/A

@yongruilin yongruilin requested a review from a team as a code owner September 5, 2023 06:40
@yongruilin
Copy link
Contributor Author

@beeme1mr @Kavindu-Dodan PTAL, thanks!

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #214 (70f7dba) into main (68f0c7b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files          10       10           
  Lines        1203     1203           
=======================================
  Hits          946      946           
  Misses        230      230           
  Partials       27       27           
Files Changed Coverage Δ
pkg/openfeature/memprovider/in_memory_provider.go 75.59% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: yongruilin <yongrlin@outlook.com>
@beeme1mr beeme1mr merged commit a98950d into open-feature:main Sep 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants