Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: improve eventing #248

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Jan 30, 2024

This PR

Contains minor improvements on the eventing of the SDK

  • Expose the provider name from EventDetails
  • Add buffer to internal channel handler to improve concurrency: Buffer should theoretically allow us to handle events in order of they are received

@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner January 30, 2024 23:16
@Kavindu-Dodan Kavindu-Dodan changed the title Chore: improve eventing chore: improve eventing Jan 30, 2024
@open-feature open-feature deleted a comment from github-actions bot Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95f592a) 81.61% compared to head (b1d3aad) 81.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files          10       10           
  Lines        1142     1142           
=======================================
  Hits          932      932           
  Misses        192      192           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/improve-eventing branch from 677ce4a to b1d3aad Compare January 31, 2024 23:22
@Kavindu-Dodan Kavindu-Dodan merged commit d2c1636 into open-feature:main Jan 31, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants