Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Domain-scoped clients are not usable initially #310

Closed
toddbaert opened this issue Nov 28, 2024 · 2 comments
Closed

Domain-scoped clients are not usable initially #310

toddbaert opened this issue Nov 28, 2024 · 2 comments
Assignees
@warber
Labels
bug Something isn't working

Comments

@toddbaert
Copy link
Member

toddbaert commented Nov 28, 2024 •
edited
Loading

Domain scoped clients should default to the default provider, which is always usable (no-ops) but doesn't not emit READY events.

This seems to be a regression around our new stateless provider functionality implemented in #299

Background

          Reported in Slack: https://cloud-native.slack.com/archives/C06HAN9KP9Q/p1732715248777879?thread_ts=1732656743.817279&cid=C06HAN9KP9Q

From Roman:

It has a breaking change from client usage. Before client := of.NewClient("app")  fallbacks to default provider, but now it says that provider not yet initialized.

Originally posted by @beeme1mr in #296 (review)
@toddbaert toddbaert changed the title domain-scoped clients are not initialized \Domain-scoped clients are not usable initially Nov 28, 2024
@toddbaert toddbaert changed the title \Domain-scoped clients are not usable initially Domain-scoped clients are not usable initially Nov 28, 2024
@toddbaert toddbaert added the bug Something isn't working label Nov 28, 2024
@warber warber mentioned this issue Dec 2, 2024
Merged
@erka
Copy link

erka commented Dec 5, 2024

Great work @warber !

Could we close this? Github haven't done it automatically

@beeme1mr
Copy link
Member

beeme1mr commented Dec 5, 2024

Resolved by #309

@beeme1mr beeme1mr closed this as completed Dec 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@warber warber

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erka @beeme1mr @toddbaert @warber