Skip to content

Commit bc18dc2

Browse files
Fix the playwright tests
1 parent e3cd2bc commit bc18dc2

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/ApiServiceRest.spec.ts

+2
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ test.describe('API service', () => {
5656
await page.locator('#root\\/token').fill(apiServiceConfig.token);
5757
await page.getByTestId('submit-btn').click();
5858

59+
await page.getByTestId('submit-btn').getByText('Save').click();
60+
5961
// step 3
6062
await page.getByTestId('view-service-button').click();
6163

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/ServiceIngestion.spec.ts

+2
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ if (process.env.PLAYWRIGHT_IS_OSS) {
5757
// use the admin user to login
5858
test.use({
5959
storageState: 'playwright/.auth/admin.json',
60+
trace: process.env.PLAYWRIGHT_IS_OSS ? 'off' : 'on-first-retry',
61+
video: process.env.PLAYWRIGHT_IS_OSS ? 'on' : 'off',
6062
});
6163

6264
services.forEach((ServiceClass) => {

openmetadata-ui/src/main/resources/ui/playwright/support/entity/ingestion/BigQueryIngestionClass.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,9 @@ class BigQueryIngestionClass extends ServiceBaseClass {
7979
)}`
8080
);
8181
await checkServiceFieldSectionHighlighting(page, 'clientX509CertUrl');
82-
await page.click('[data-testid="add-item-Taxonomy Project IDs"]');
83-
await checkServiceFieldSectionHighlighting(page, 'taxonomyProjectID');
84-
await page.fill('#root\\/taxonomyProjectID\\/0', projectIdTaxonomy);
85-
await checkServiceFieldSectionHighlighting(page, 'taxonomyProjectID');
82+
83+
await page.fill(`#root\\/taxonomyProjectID`, projectIdTaxonomy);
84+
await page.locator(`#root\\/taxonomyProjectID`).press('Enter');
8685
}
8786

8887
async fillIngestionDetails(page: Page) {

openmetadata-ui/src/main/resources/ui/playwright/support/entity/ingestion/S3IngestionClass.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ class S3IngestionClass extends ServiceBaseClass {
5555
await checkServiceFieldSectionHighlighting(page, 'awsRegion');
5656

5757
// to reduce ingestion time
58-
await page.click('[data-testid="add-item-Bucket Names"]');
59-
await page.fill('#root\\/bucketNames\\/0', this.entityName);
58+
await page.fill('#root\\/bucketNames', this.entityName);
59+
await page.locator('#root\\/bucketNames').press('Enter');
6060
}
6161

6262
async fillIngestionDetails(page: Page) {

0 commit comments

Comments
 (0)