Skip to content

Commit ce3f55a

Browse files
URL for repos (#31)
* URL for repos * F2C namespace * try using public repos * update test * try catch * lint. * try removing shutdown * move to cyclone * -y * wait for action server * try checkout again * configurability of distribution
1 parent e6b8acf commit ce3f55a

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

.github/deps.repos

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
repositories:
2-
Fields2Cover/Fields2Cover:
2+
Fields2Cover:
33
type: git
44
url: https://github.com/Fields2Cover/Fields2Cover.git
55
version: main

.github/workflows/test.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,24 @@ jobs:
1010
runs-on: ubuntu-latest
1111
env:
1212
ROS_DISTRO: ${{ matrix.ros_distro }}
13+
RMW_IMPLEMENTATION: rmw_cyclonedds_cpp
1314
container:
1415
image: rostooling/setup-ros-docker:ubuntu-jammy-latest
1516
strategy:
1617
fail-fast: false
1718
matrix:
1819
ros_distro: [iron]
1920
steps:
21+
- uses: actions/checkout@v2
22+
- name: Install Cyclone DDS
23+
run: sudo apt install ros-${{ matrix.ros_distro }}-rmw-cyclonedds-cpp -y
2024
- name: Build and run tests
2125
id: action-ros-ci
2226
uses: ros-tooling/action-ros-ci@v0.3
2327
with:
2428
import-token: ${{ secrets.GITHUB_TOKEN }}
2529
target-ros2-distro: ${{ matrix.ros_distro }}
26-
vcs-repo-file-url: ./.github/deps.repos
30+
vcs-repo-file-url: "${{ github.workspace }}/.github/deps.repos"
2731
- uses: actions/upload-artifact@v1
2832
with:
2933
name: colcon-logs

opennav_coverage/test/test_server.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ TEST(ServerTest, testServerTransactions)
9393
auto action_client =
9494
rclcpp_action::create_client<opennav_coverage_msgs::action::ComputeCoveragePath>(
9595
client_node, "compute_coverage_path");
96+
action_client->wait_for_action_server();
9697

9798
auto goal_msg = opennav_coverage_msgs::action::ComputeCoveragePath::Goal();
9899
goal_msg.use_gml_file = true; // Use file

opennav_coverage_bt/test/test_compute_coverage_path.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ class ComputeCoveragePathActionTestFixture : public ::testing::Test
8787

8888
static void TearDownTestCase()
8989
{
90+
factory_.reset();
91+
action_server_.reset();
9092
delete config_;
9193
config_ = nullptr;
9294
node_.reset();
93-
action_server_.reset();
94-
factory_.reset();
9595
}
9696

9797
void TearDown() override
@@ -166,7 +166,7 @@ int main(int argc, char ** argv)
166166
int all_successful = RUN_ALL_TESTS();
167167

168168
// shutdown ROS
169-
rclcpp::shutdown();
169+
// rclcpp::shutdown();
170170
server_thread.join();
171171

172172
return all_successful;

0 commit comments

Comments
 (0)