-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Algorithm enablement #1331
Comments
I agree with the categories you propose. Since some algs in the EXPERIMENTAL bucket might not be "experimental" but simply non-NIST (e.g., Frodo selected by BSI, OpenSSH's ntru), then we could perhaps rename it: ALL. |
Completely agreed. So also reads the comment in the new code :-) Open question remaining: What alg names shall be on the list of NIST_R4? |
NIST_R4 would for now be BIKE, HQC, and Classic McEliece. Once there have been submissions to the additional call for signatures, we could add to that or create a separate flag for that. |
In terms of dealing with the downstream build problems that came when I prematurely merged #1333, what about changing it so that that the default is ALL, so that all the downstream tests will see an unchanged list of algorithms. Expert users can use the added liboqs CMake option to build a subset of the algorithms. At this point in time they'd also need to regenerate code in the downstream projects if they wanted to build against that subset of algorithms, but perhaps someday we'd find the time to do something smoother. |
So changed in #1355 |
Following up on #1245 (comment) this is to propose implementing a
cmake
build option labelled "OQS_ALGS_ENABLED" with the following possible values and effects:Proposed default value: "STD" (also to be activated if "OQS_ALGS_ENABLED" is not explicitly set).
Comments/alternative proposals welcome before implementing as described.
The text was updated successfully, but these errors were encountered: