Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Target install does nothing with static oqsprovider.a library #439

Closed
maroueneboubakri opened this issue Jun 25, 2024 · 2 comments · Fixed by #441
Closed

Target install does nothing with static oqsprovider.a library #439

maroueneboubakri opened this issue Jun 25, 2024 · 2 comments · Fixed by #441
Labels
bug Something isn't working

Comments

@maroueneboubakri
Copy link

Hello,

The provider could be used as standalone library to be statically linked with a binary. Therefore, it makes sense that cmake --install or cmake --build . --target install installs the static library into lib folder. While nothing happens when those are invoked.

-- Install configuration: ""

Kindly consider this use case.

Br
Maro

@maroueneboubakri maroueneboubakri added the bug Something isn't working label Jun 25, 2024
@ghost ghost self-assigned this Jun 25, 2024
@maroueneboubakri
Copy link
Author

Also kindly keep consider naming liboqsprovider.a for static library to ease linking against it with gcc -loqsprovider instead of providing path to to oqsprovider.a.

@ghost
Copy link

ghost commented Jun 25, 2024

Hi @maroueneboubakri, thank you for raising that issue.

Actually, you should be able to get your oqsprovider.a installed under your ${CMAKE_INSTALL_PREFIX} by using Debug or Release build type:

install(TARGETS oqsprovider
CONFIGURATIONS Debug Release
LIBRARY DESTINATION "${OPENSSL_MODULES_PATH}"
RUNTIME DESTINATION "${OPENSSL_MODULES_PATH}")

With an empty ${CMAKE_BUILD_TYPE} it installs nothing though.

I fixed this odd behavior, and I renamed oqsprovider.a to liboqsprovider.a (only if you build it statically) in #441.

I also added a CI test for it.

@ghost ghost closed this as completed in e3a8d62 Jun 26, 2024
@ghost ghost closed this as completed in #441 Jun 26, 2024
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant