Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provenance #44

Closed
skearnes opened this issue Mar 12, 2020 · 1 comment · Fixed by #56
Closed

Provenance #44

skearnes opened this issue Mar 12, 2020 · 1 comment · Fixed by #56

Comments

@skearnes
Copy link
Member

We need to keep track of enough information to handle (at least) the following cases:

  • Person A ran an experiment and Person B created the proto describing it.
  • Person C made a mistake while creating a record and submits a correction.

Keeping pointers to the original submission artifacts will cover many of these cases, but we probably need to expand the Provenance message to contain these pointers and additional information about the submitter/creator (not just the experimenter). The guiding principle, I think, is "do we know who we should talk to if there's a problem?"

Related to this is the question of duplicates (we may just want to ignore these?):

  • Person E and Person F both extracted the same reaction from a publication (possibly with slightly different details or even enum values).
@connorcoley
Copy link
Collaborator

I agree, if we want to keep that bookkeeping with the protos themselves rather than in an auxilliary database (e.g., that assigns a unique ID to each proto and logs all of the edits).

Re: expanding the Provenance, should we have a repeated RecordModification modifications where a RecordModification contains a DateTime, Person, and maybe a string details?

Not sure about duplicates. We may want to ignore that problem for now. I don't know how many people will actually go back through historical data.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants