Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add check to prevent the same buffer appearing more than once in a single join #61

Open
mxgrey opened this issue Mar 20, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Mar 20, 2025

Right now it is technically possible for a user to specify the same buffer multiple times within one join operation, but this would result in a Broken error while the workflow is running.

We should instead check whether the same buffer has been put multiple times into the join while building the join instead of risking a runtime problem. We can introduce a new safe_join method that returns a Result, and the existing join method just unwraps safe_join.

@mxgrey mxgrey added the bug Something isn't working label Mar 20, 2025
@mxgrey mxgrey added this to PMC Board Mar 20, 2025
@github-project-automation github-project-automation bot moved this to Inbox in PMC Board Mar 20, 2025
@mxgrey mxgrey moved this from Inbox to Todo in PMC Board Mar 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant