Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Logging for .NET Framework applications #2310

Open
Kronos11 opened this issue Mar 9, 2023 · 8 comments
Open

Enable Logging for .NET Framework applications #2310

Kronos11 opened this issue Mar 9, 2023 · 8 comments
Milestone

Comments

@Kronos11
Copy link
Contributor

Kronos11 commented Mar 9, 2023

Feature Request

Are you requesting automatic instrumentation for a framework or library? Please describe.

  • Framework or library name : [ILogger]
  • Library type: [Logging]
  • Library version: [Framework 4.6.2+]

Is your feature request related to a problem? Please describe.
It's vital we have Logging support in our .NET Framework applications, our application can implement an ILogger solution, but we need them to be picked up by the instrumentation.

Describe the solution you'd like
Automatic support for ILogger in .NET Framework

Describe alternatives you've considered
Considering writing to a file and having the Collector tail the file to be added.

Additional context
Slack conversation: https://cloud-native.slack.com/archives/C01NR1YLSE7/p1678375665847919

@pjanotti pjanotti added this to the 1.0.0-rc milestone Mar 15, 2023
@rajkumar-rangaraj
Copy link
Contributor

@Kronos11 I started my work on this issue. Could you please provide a sample app for me to test it.

@Kronos11
Copy link
Contributor Author

@Kronos11 I started my work on this issue. Could you please provide a sample app for me to test it.

I will work on a sample app example.

@rajkumar-rangaraj
Copy link
Contributor

@Kronos11 Here are our CI bits from the PR - https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/suites/12008283502/artifacts/630686154. Could you please use this package and test if the logs are exported as expected? Thank you!

@Kronos11
Copy link
Contributor Author

Kronos11 commented Apr 5, 2023

@Kronos11 Here are our CI bits from the PR - https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/suites/12008283502/artifacts/630686154. Could you please use this package and test if the logs are exported as expected? Thank you!

I've done a few small tests, but this does seem to be working on a webforms application as well.

@Kielek Kielek removed this from the 1.0.0-rc.1 milestone Apr 27, 2023
@nrcventura nrcventura added this to the 1.0.0-rc.2 milestone May 3, 2023
@nrcventura nrcventura moved this from In progress to Backlog in OpenTelemetry .NET Automatic Instrumentation May 3, 2023
@Kielek Kielek modified the milestones: 1.0.0-rc.2, post-1.0.0 Jun 26, 2023
@Kielek
Copy link
Contributor

Kielek commented Jun 26, 2023

Moving pos-GA after sync wyth @rajkumar-rangaraj .

@Kielek
Copy link
Contributor

Kielek commented Jan 23, 2024

Removing milestone per @lachmatt suggestion.

@rajkumar-rangaraj, OTLP is stable now. Can we revisit this?

@Kielek
Copy link
Contributor

Kielek commented Jan 31, 2024

SIG notes: Technically it should be possible. Moving back to vNext. Can be picked upped based on the contributor priorities

@Kielek Kielek added this to the vNext milestone Jan 31, 2024
@chamildz
Copy link

chamildz commented Aug 7, 2024

@Kielek I wanted to check if you still plan add automatic logging instrumentation support for .NET Framework applications in the near future.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants