[Exporter.InMemory] - enable analysis (#6165)

Author: Kielek

build/Common.nonprod.props

@@ -2,7 +2,7 @@
   <Import Project=".\Common.props" />
 
   <PropertyGroup>
-    <NoWarn>$(NoWarn),1574,1591</NoWarn>
+    <NoWarn>$(NoWarn),CS1574,CS1591</NoWarn>
     <IsPackable>false</IsPackable>
     <CodeAnalysisRuleSet>$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), 'OpenTelemetry.sln'))\build\OpenTelemetry.test.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>

src/OpenTelemetry.Api/Trace/TelemetrySpan.cs

@@ -45,9 +45,9 @@ public ActivitySpanId ParentSpanId
     /// <param name="value">Status to be set.</param>
     public void SetStatus(Status value)
     {
-#pragma warning disable
+#pragma warning disable CS0618 // Type or member is obsolete
         this.Activity.SetStatus(value);
-#pragma warning restore
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     /// <summary>

src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj

@@ -9,7 +9,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <NoWarn>$(NoWarn),1591</NoWarn>
+    <NoWarn>$(NoWarn),CS1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

src/OpenTelemetry.Exporter.InMemory/InMemoryExporterHelperExtensions.cs

@@ -20,6 +20,8 @@ public static TracerProviderBuilder AddInMemoryExporter(this TracerProviderBuild
         Guard.ThrowIfNull(builder);
         Guard.ThrowIfNull(exportedItems);
 
+#pragma warning disable CA2000 // Dispose objects before losing scope
         return builder.AddProcessor(new SimpleActivityExportProcessor(new InMemoryExporter<Activity>(exportedItems)));
+#pragma warning restore CA2000 // Dispose objects before losing scope
     }
 }

src/OpenTelemetry.Exporter.InMemory/InMemoryExporterLoggingExtensions.cs

@@ -22,10 +22,12 @@ public static OpenTelemetryLoggerOptions AddInMemoryExporter(
         Guard.ThrowIfNull(loggerOptions);
         Guard.ThrowIfNull(exportedItems);
 
+#pragma warning disable CA2000 // Dispose objects before losing scope
         var logExporter = BuildExporter(exportedItems);
 
         return loggerOptions.AddProcessor(
             new SimpleLogRecordExportProcessor(logExporter));
+#pragma warning restore CA2000 // Dispose objects before losing scope
     }
 
     /// <summary>
@@ -41,10 +43,12 @@ public static LoggerProviderBuilder AddInMemoryExporter(
         Guard.ThrowIfNull(loggerProviderBuilder);
         Guard.ThrowIfNull(exportedItems);
 
+#pragma warning disable CA2000 // Dispose objects before losing scope
         var logExporter = BuildExporter(exportedItems);
 
         return loggerProviderBuilder.AddProcessor(
             new SimpleLogRecordExportProcessor(logExporter));
+#pragma warning restore CA2000 // Dispose objects before losing scope
     }
 
     private static InMemoryExporter<LogRecord> BuildExporter(ICollection<LogRecord> exportedItems)

src/OpenTelemetry.Exporter.InMemory/InMemoryExporterMetricsExtensions.cs

@@ -147,11 +147,13 @@ public static MeterProviderBuilder AddInMemoryExporter(
         });
     }
 
-    private static MetricReader BuildInMemoryExporterMetricReader(
+    private static PeriodicExportingMetricReader BuildInMemoryExporterMetricReader(
         ICollection<Metric> exportedItems,
         MetricReaderOptions metricReaderOptions)
     {
+#pragma warning disable CA2000 // Dispose objects before losing scope
         var metricExporter = new InMemoryExporter<Metric>(exportedItems);
+#pragma warning restore CA2000 // Dispose objects before losing scope
 
         return PeriodicExportingMetricReaderHelper.CreatePeriodicExportingMetricReader(
             metricExporter,
@@ -160,12 +162,14 @@ private static MetricReader BuildInMemoryExporterMetricReader(
             DefaultExportTimeoutMilliseconds);
     }
 
-    private static MetricReader BuildInMemoryExporterMetricReader(
+    private static PeriodicExportingMetricReader BuildInMemoryExporterMetricReader(
         ICollection<MetricSnapshot> exportedItems,
         MetricReaderOptions metricReaderOptions)
     {
+#pragma warning disable CA2000 // Dispose objects before losing scope
         var metricExporter = new InMemoryExporter<Metric>(
             exportFunc: (in Batch<Metric> metricBatch) => ExportMetricSnapshot(in metricBatch, exportedItems));
+#pragma warning restore CA2000 // Dispose objects before losing scope
 
         return PeriodicExportingMetricReaderHelper.CreatePeriodicExportingMetricReader(
             metricExporter,

src/OpenTelemetry.Exporter.InMemory/MetricSnapshot.cs

@@ -1,6 +1,8 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
+using OpenTelemetry.Internal;
+
 namespace OpenTelemetry.Metrics;
 
 /// <summary>
@@ -14,10 +16,11 @@ public class MetricSnapshot
 
     public MetricSnapshot(Metric metric)
     {
+        Guard.ThrowIfNull(metric);
         this.instrumentIdentity = metric.InstrumentIdentity;
         this.MetricType = metric.MetricType;
 
-        List<MetricPoint> metricPoints = new();
+        List<MetricPoint> metricPoints = [];
         foreach (ref readonly var metricPoint in metric.GetMetricPoints())
         {
             metricPoints.Add(metricPoint.Copy());

src/OpenTelemetry.Exporter.InMemory/OpenTelemetry.Exporter.InMemory.csproj

@@ -1,14 +1,15 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>$(TargetFrameworksForLibraries)</TargetFrameworks>
     <Description>In-memory exporter for OpenTelemetry .NET</Description>
     <PackageTags>$(PackageTags)</PackageTags>
     <MinVerTagPrefix>core-</MinVerTagPrefix>
+    <AnalysisLevel>latest-all</AnalysisLevel>
   </PropertyGroup>
 
   <PropertyGroup>
-    <NoWarn>$(NoWarn),1591</NoWarn>
+    <NoWarn>$(NoWarn),CS1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

src/OpenTelemetry.Extensions.Propagators/OpenTelemetry.Extensions.Propagators.csproj

@@ -12,7 +12,7 @@
   </ItemGroup>
 
   <PropertyGroup>
-    <NoWarn>$(NoWarn),1591</NoWarn>
+    <NoWarn>$(NoWarn),CS1591</NoWarn>
   </PropertyGroup>
 
 </Project>

src/OpenTelemetry/Trace/Processor/ExceptionProcessor.cs

@@ -62,9 +62,9 @@ public override void OnEnd(Activity activity)
 
         if (snapshot != pointers)
         {
-#pragma warning disable
+#pragma warning disable CS0618 // Type or member is obsolete
             activity.SetStatus(Status.Error);
-#pragma warning restore
+#pragma warning restore CS0618 // Type or member is obsolete
         }
     }
 }