Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

skip certain tests when running on ARM #5906

Open
TimothyMothra opened this issue Oct 16, 2024 · 1 comment
Open

skip certain tests when running on ARM #5906

TimothyMothra opened this issue Oct 16, 2024 · 1 comment
Labels
enhancement New feature or request needs-triage New issues which have not been classified or triaged by a community member pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Comments

@TimothyMothra
Copy link
Contributor

Package

OpenTelemetry.Exporter.OpenTelemetryProtocol

Is your feature request related to a problem?

I was experimenting with Windows on ARM and found one group of tests that fail.

This test fails when targeting net462, but pass when targeting either net8 or net9.

OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests
	
System.IO.IOException : Error loading native library "C:\REPOS\opentelemetry-dotnet\test\OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests\bin\Debug\net462\grpc_csharp_ext.x64.dll". LoadLibrary failed with error 193

Stack Trace: 
	UnmanagedLibrary.ctor(String[] libraryPathAlternatives)
	NativeExtension.LoadNativeMethodsUsingExplicitLoad()
	NativeExtension.ctor()
	NativeExtension.Get()
	GrpcEnvironment.GrpcNativeInit()
	GrpcEnvironment.ctor()
	GrpcEnvironment.AddRef()
	Channel.ctor(String target, ChannelCredentials credentials, IEnumerable`1 options)
	OtlpExporterOptionsExtensions.CreateChannel(OtlpExporterOptions options) line 49
	OtlpGrpcTraceExportClient.ctor(OtlpExporterOptions options, TraceServiceClient traceServiceClient) line 23

Blanch wrote a way to skip certain platforms in the contrib repo:
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/b8fe2cb419738f41c0855c25dbe77bb75de10a98/test/OpenTelemetry.Exporter.Geneva.Tests/UnixUserEventsDataTransportTests.cs#L55

I'm proposing that we consider something similar here:

What is the expected behavior?

N/A

Which alternative solutions or features have you considered?

N/A

Additional context

No response

@TimothyMothra TimothyMothra added enhancement New feature or request needs-triage New issues which have not been classified or triaged by a community member labels Oct 16, 2024
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Oct 16, 2024
@TimothyMothra
Copy link
Contributor Author

The OTLP implementation was being rewritten so this may not be an issue when that effort is complete.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request needs-triage New issues which have not been classified or triaged by a community member pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

No branches or pull requests

1 participant