-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Support for CloudFoundry Resource Attributes #12861
Comments
@KarstenSchnitter thanks for the suggestion, I think CF users would find this helpful. We typically put vendor-specific (in this case cloud-vendor specific) implementations over in the contrib repo (see the aws and gcp implementations over there). Once that happens, vendors can choose to include these I'm inclined to move this issue to the contrib repo, if that's cool with everyone... |
@laurit suggested the same in the associated PR #12862. Still, I want to point out, that CloudFoundry is a CNCF project just like Kubernetes and much more vendor-agnostic than AWS or GCP. I would prefer having this instrumentation available without an additional extension, but I can work with that solution as well. |
Sorry, I missed that the conversation had already been started over there. Can you link to documentation that shows CloudFoundry as a CNCF project? I couldn't find any evidence of that being a true statement, but might have just overlooked it. |
Sorry, I got it a little mixed up. CloudFoundry is not a CNCF project, but the CloudFoundry Foundation is part of the Linux Foundation: https://www.cloudfoundry.org/foundation/ |
Having the resource provider in contrib repository does not prevent it from being included in the agent. Both gcp and aws resource providers are included in the agent, although they are disabled by default. |
Is your feature request related to a problem? Please describe.
When running an application as a CloudFoundry deployment, the Cloud Foundry attributes should be filled automatically. This allows connecting the observability data with the application metadata as used by Cloud Foundry.
Describe the solution you'd like
An application deployed to Cloud Foundry receives the necessary metadata in the environment variable
VCAP_APPLICATION
. The contents of this variable is a JSON document whose fields can be mapped to the CloudFoundry attributes by the following mapping.All of this can be done in a
ResourceProvider
, that searches for the environment variableVCAP_APPLICATION
and applies this mapping, if it is found.Describe alternatives you've considered
CloudFoundry developers can run custom extensions on the Java Agent to provide this functionality.
Additional context
No response
The text was updated successfully, but these errors were encountered: