Skip to content

Commit 3e683b4

Browse files
committedFeb 28, 2024
Remove [test] package from mysqlclient instrumentation
Fixes #2208
1 parent 8daa8ad commit 3e683b4

File tree

3 files changed

+21
-6
lines changed

3 files changed

+21
-6
lines changed
 

‎instrumentation/opentelemetry-instrumentation-mysqlclient/pyproject.toml

-4
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ dependencies = [
3333
instruments = [
3434
"mysqlclient < 3",
3535
]
36-
test = [
37-
"opentelemetry-instrumentation-mysqlclient[instruments]",
38-
"opentelemetry-test-utils == 0.45b0.dev",
39-
]
4036

4137
[project.entry-points.opentelemetry_instrumentor]
4238
mysqlclient = "opentelemetry.instrumentation.mysqlclient:MySQLClientInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
importlib-metadata==6.11.0
5+
iniconfig==2.0.0
6+
mysqlclient==2.2.4
7+
packaging==23.2
8+
pluggy==1.4.0
9+
py==1.11.0
10+
py-cpuinfo==9.0.0
11+
pytest==7.1.3
12+
pytest-benchmark==4.0.0
13+
tomli==2.0.1
14+
typing_extensions==4.9.0
15+
wrapt==1.16.0
16+
zipp==3.17.0
17+
-e ../../../opentelemetry-instrumentation
18+
-e ../../../instrumentation/opentelemetry-instrumentation-dbapi
19+
-e ../../../instrumentation/opentelemetry-instrumentation-mysqlclient

‎tox.ini

+2-2
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ commands_pre =
424424

425425
mysql: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-dbapi {toxinidir}/instrumentation/opentelemetry-instrumentation-mysql[test]
426426

427-
mysqlclient: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-dbapi {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient[test]
427+
mysqlclient: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient/test-requirements.txt
428428

429429
pymemcache-{135,200,300,342,400}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-pymemcache[test]
430430

@@ -575,7 +575,7 @@ commands_pre =
575575
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pymysql[test]
576576
# prerequisite: follow the instructions here https://github.com/PyMySQL/mysqlclient#install
577577
# for your OS to install the required dependencies
578-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient[test]
578+
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient
579579
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pymongo[test]
580580
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch[test]
581581
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncpg[test]

0 commit comments

Comments
 (0)