Skip to content

Commit 6f7e3bb

Browse files
committed
Remove [test] package from urllib instrumentation
Fixes #2225
1 parent 565e78d commit 6f7e3bb

File tree

3 files changed

+22
-7
lines changed

3 files changed

+22
-7
lines changed

instrumentation/opentelemetry-instrumentation-urllib/pyproject.toml

-4
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ dependencies = [
3232

3333
[project.optional-dependencies]
3434
instruments = []
35-
test = [
36-
"httpretty ~= 1.0",
37-
"opentelemetry-test-utils == 0.45b0.dev",
38-
]
3935

4036
[project.entry-points.opentelemetry_instrumentor]
4137
urllib = "opentelemetry.instrumentation.urllib:URLLibInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
httpretty==1.1.4
5+
importlib-metadata==6.11.0
6+
iniconfig==2.0.0
7+
packaging==23.2
8+
pluggy==1.4.0
9+
py==1.11.0
10+
py-cpuinfo==9.0.0
11+
pytest==7.1.3
12+
pytest-benchmark==4.0.0
13+
tomli==2.0.1
14+
typing_extensions==4.9.0
15+
wrapt==1.16.0
16+
zipp==3.17.0
17+
-e opentelemetry-instrumentation
18+
-e util/opentelemetry-util-http
19+
-e instrumentation/opentelemetry-instrumentation-urllib

tox.ini

+3-3
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ commands_pre =
333333

334334
grpc: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
335335

336-
falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,asgi,httpx-{18,21},requests,urllib,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
336+
falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,asgi,httpx-{18,21},requests,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
337337
wsgi,falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi[test]
338338
asgi,django-{3,4},starlette,fastapi: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asgi[test]
339339

@@ -350,7 +350,7 @@ commands_pre =
350350

351351
flask-{213,220,300}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
352352

353-
urllib: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
353+
urllib: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt
354354

355355
urllib3v-{1,2}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3[test]
356356

@@ -567,7 +567,7 @@ commands_pre =
567567
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlite3[test]
568568
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pyramid[test]
569569
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-requests[test]
570-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
570+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt
571571
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3[test]
572572
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pymysql[test]
573573
# prerequisite: follow the instructions here https://github.com/PyMySQL/mysqlclient#install

0 commit comments

Comments
 (0)