Fix Azure resource detector dependency

jeremydvoss · jeremydvoss · commit c28ff4da5f7f · 2023-11-27T14:40:53.000-08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - `opentelemetry-instrumentation-urllib`/`opentelemetry-instrumentation-urllib3` Fix metric descriptions to match semantic conventions
   ([#1959]((https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1959))
+- `opentelemetry-resource-detector-azure` Added dependency for Cloud Resource ID attribute and clearer logging for Azure Resource Detectors
+  ([#2072](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2072))
   
 ## Version 1.21.0/0.42b0 (2023-11-01)
 
diff --git a/resource/opentelemetry-resource-detector-azure/pyproject.toml b/resource/opentelemetry-resource-detector-azure/pyproject.toml
@@ -25,7 +25,7 @@ classifiers = [
   "Programming Language :: Python :: 3.11",
 ]
 dependencies = [
-  "opentelemetry-sdk ~= 1.19",
+  "opentelemetry-sdk ~= 1.21",
 ]
 
 [project.optional-dependencies]
diff --git a/resource/opentelemetry-resource-detector-azure/src/opentelemetry/resource/detector/azure/vm.py b/resource/opentelemetry-resource-detector-azure/src/opentelemetry/resource/detector/azure/vm.py
@@ -24,7 +24,6 @@
     ResourceAttributes,
 )
 
-# TODO: Remove when cloud resource id is no longer missing in Resource Attributes
 _AZURE_VM_METADATA_ENDPOINT = "http://169.254.169.254/metadata/instance/compute?api-version=2021-12-13&format=json"
 _AZURE_VM_SCALE_SET_NAME_ATTRIBUTE = "azure.vm.scaleset.name"
 _AZURE_VM_SKU_ATTRIBUTE = "azure.vm.sku"

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ classifiers = [`
`25`	`25`	`"Programming Language :: Python :: 3.11",`
`26`	`26`	`]`
`27`	`27`	`dependencies = [`
`28`		`- "opentelemetry-sdk ~= 1.19",`
	`28`	`+ "opentelemetry-sdk ~= 1.21",`
`29`	`29`	`]`
`30`	`30`
`31`	`31`	`[project.optional-dependencies]`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`ResourceAttributes,`
`25`	`25`	`)`
`26`	`26`
`27`		`-# TODO: Remove when cloud resource id is no longer missing in Resource Attributes`
`28`	`27`	`_AZURE_VM_METADATA_ENDPOINT = "http://169.254.169.254/metadata/instance/compute?api-version=2021-12-13&format=json"`
`29`	`28`	`_AZURE_VM_SCALE_SET_NAME_ATTRIBUTE = "azure.vm.scaleset.name"`
`30`	`29`	`_AZURE_VM_SKU_ATTRIBUTE = "azure.vm.sku"`