Skip to content

Commit d1c3cb3

Browse files
authored
Remove [test] package from httpx instrumentation (#2314)
Fixes #2203
1 parent 28f49a5 commit d1c3cb3

File tree

4 files changed

+76
-25
lines changed

4 files changed

+76
-25
lines changed

instrumentation/opentelemetry-instrumentation-httpx/pyproject.toml

-5
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@ dependencies = [
3434
instruments = [
3535
"httpx >= 0.18.0",
3636
]
37-
test = [
38-
"opentelemetry-instrumentation-httpx[instruments]",
39-
"opentelemetry-sdk ~= 1.12",
40-
"opentelemetry-test-utils == 0.45b0.dev",
41-
]
4237

4338
[project.entry-points.opentelemetry_instrumentor]
4439
httpx = "opentelemetry.instrumentation.httpx:HTTPXClientInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
anyio==3.7.1
2+
asgiref==3.7.2
3+
attrs==23.2.0
4+
certifi==2024.2.2
5+
Deprecated==1.2.14
6+
exceptiongroup==1.2.0
7+
h11==0.12.0
8+
httpcore==0.13.7
9+
httpx==0.18.2
10+
idna==3.6
11+
importlib-metadata==6.11.0
12+
iniconfig==2.0.0
13+
packaging==23.2
14+
pluggy==1.4.0
15+
py==1.11.0
16+
py-cpuinfo==9.0.0
17+
pytest==7.1.3
18+
pytest-benchmark==4.0.0
19+
respx==0.17.1
20+
rfc3986==1.5.0
21+
sniffio==1.3.1
22+
tomli==2.0.1
23+
typing_extensions==4.10.0
24+
wrapt==1.16.0
25+
zipp==3.17.0
26+
-e opentelemetry-instrumentation
27+
-e util/opentelemetry-util-http
28+
-e instrumentation/opentelemetry-instrumentation-httpx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
anyio==4.3.0
2+
asgiref==3.7.2
3+
attrs==23.2.0
4+
certifi==2024.2.2
5+
Deprecated==1.2.14
6+
exceptiongroup==1.2.0
7+
h11==0.14.0
8+
httpcore==1.0.4
9+
httpx==0.27.0
10+
idna==3.6
11+
importlib-metadata==6.11.0
12+
iniconfig==2.0.0
13+
packaging==23.2
14+
pluggy==1.4.0
15+
py==1.11.0
16+
py-cpuinfo==9.0.0
17+
pytest==7.1.3
18+
pytest-benchmark==4.0.0
19+
respx==0.20.2
20+
sniffio==1.3.1
21+
tomli==2.0.1
22+
typing_extensions==4.10.0
23+
wrapt==1.16.0
24+
zipp==3.17.0
25+
-e opentelemetry-instrumentation
26+
-e util/opentelemetry-util-http
27+
-e instrumentation/opentelemetry-instrumentation-httpx

tox.ini

+21-20
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,8 @@ envlist =
221221
pypy3-test-instrumentation-tortoiseorm
222222

223223
; opentelemetry-instrumentation-httpx
224-
py3{8,9,10,11}-test-instrumentation-httpx-{18,21}
225-
pypy3-test-instrumentation-httpx-{18,21}
224+
py3{8,9,10,11}-test-instrumentation-httpx-{0,1}
225+
pypy3-test-instrumentation-httpx-{0,1}
226226

227227
; opentelemetry-util-http
228228
py3{8,9,10,11}-test-util-http
@@ -300,10 +300,6 @@ deps =
300300
pymemcache-300: pymemcache >3.0.0,<3.4.2
301301
pymemcache-342: pymemcache ==3.4.2
302302
pymemcache-400: pymemcache ==4.0.0
303-
httpx-18: httpx>=0.18.0,<0.19.0
304-
httpx-18: respx~=0.17.0
305-
httpx-21: httpx>=0.19.0
306-
httpx-21: respx~=0.20.1
307303
urllib3v-1: urllib3 >=1.0.0,<2.0.0
308304
urllib3v-2: urllib3 >=2.0.0,<3.0.0
309305

@@ -345,7 +341,7 @@ commands_pre =
345341

346342
grpc: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
347343

348-
httpx-{18,21},requests,urllib,urllib3v-{1,2}: pip install {toxinidir}/util/opentelemetry-util-http
344+
requests,urllib,urllib3v-{1,2}: pip install {toxinidir}/util/opentelemetry-util-http
349345

350346
wsgi: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi/test-requirements.txt
351347

@@ -422,7 +418,7 @@ commands_pre =
422418

423419
logging: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-logging[test]
424420

425-
aio-pika-{8,9}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-aio-pika[test]
421+
aio-pika-{0,1,2}: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-aio-pika/test-requirements-2.txt
426422

427423
aiohttp-client: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-aiohttp-client/test-requirements.txt
428424

@@ -442,7 +438,12 @@ commands_pre =
442438

443439
asyncio: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio/test-requirements.txt
444440

445-
httpx-{18,21}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx[test]
441+
; The numbers at the end of the environment names
442+
; below mean these dependencies are being used:
443+
; 0: httpx>=0.18.0,<0.19.0 respx~=0.17.0
444+
; 1: httpx>=0.19.0 respx~=0.20.1
445+
httpx-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/test-requirements-0.txt
446+
httpx-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/test-requirements-1.txt
446447

447448
sdkextension-aws: pip install {toxinidir}/sdk-extension/opentelemetry-sdk-extension-aws[test]
448449

@@ -472,40 +473,40 @@ commands =
472473
test-instrumentation-cassandra: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-cassandra/tests {posargs}
473474
test-instrumentation-celery: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-celery/tests {posargs}
474475
test-instrumentation-dbapi: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-dbapi/tests {posargs}
475-
test-instrumentation-django-{1,2,3,4}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-django/tests {posargs}
476-
test-instrumentation-elasticsearch-{2,5,6}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/tests {posargs}
477-
test-instrumentation-falcon-{1,2,3}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon/tests {posargs}
476+
test-instrumentation-django: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-django/tests {posargs}
477+
test-instrumentation-elasticsearch: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/tests {posargs}
478+
test-instrumentation-falcon: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon/tests {posargs}
478479
test-instrumentation-fastapi: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-fastapi/tests {posargs}
479-
test-instrumentation-flask-{213,220,300}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/tests {posargs}
480+
test-instrumentation-flask: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/tests {posargs}
480481
test-instrumentation-urllib: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib/tests {posargs}
481-
test-instrumentation-urllib3v-{1,2}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3/tests {posargs}
482+
test-instrumentation-urllib3v: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3/tests {posargs}
482483
test-instrumentation-grpc: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc/tests {posargs}
483484
test-instrumentation-jinja2: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-jinja2/tests {posargs}
484485
test-instrumentation-kafka-python: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-kafka-python/tests {posargs}
485486
test-instrumentation-confluent-kafka: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-confluent-kafka/tests {posargs}
486487
test-instrumentation-logging: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-logging/tests {posargs}
487488
test-instrumentation-mysql: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-mysql/tests {posargs}
488489
test-instrumentation-mysqlclient: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient/tests {posargs}
489-
test-instrumentation-sio-pika-{0,1}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-pika/tests {posargs}
490-
test-instrumentation-aio-pika-{8,9}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-aio-pika/tests {posargs}
490+
test-instrumentation-sio-pika: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-pika/tests {posargs}
491+
test-instrumentation-aio-pika: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-aio-pika/tests {posargs}
491492
test-instrumentation-psycopg: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-psycopg/tests {posargs}
492493
test-instrumentation-psycopg2: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-psycopg2/tests {posargs}
493-
test-instrumentation-pymemcache-{135,200,300,342,400}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-pymemcache/tests {posargs}
494+
test-instrumentation-pymemcache: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-pymemcache/tests {posargs}
494495
test-instrumentation-pymongo: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-pymongo/tests {posargs}
495496
test-instrumentation-pymysql: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-pymysql/tests {posargs}
496497
test-instrumentation-pyramid: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-pyramid/tests {posargs}
497498
test-instrumentation-redis: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-redis/tests {posargs}
498499
test-instrumentation-remoulade: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-remoulade/tests {posargs}
499500
test-instrumentation-requests: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-requests/tests {posargs}
500501
test-instrumentation-sklearn: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-sklearn/tests {posargs}
501-
test-instrumentation-sqlalchemy-{11,14}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy/tests {posargs}
502+
test-instrumentation-sqlalchemy: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy/tests {posargs}
502503
test-instrumentation-sqlite3: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlite3/tests {posargs}
503504
test-instrumentation-starlette: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-starlette/tests {posargs}
504505
test-instrumentation-system-metrics: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-system-metrics/tests {posargs}
505506
test-instrumentation-tornado: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-tornado/tests {posargs}
506507
test-instrumentation-tortoiseorm: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-tortoiseorm/tests {posargs}
507508
test-instrumentation-wsgi: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi/tests {posargs}
508-
test-instrumentation-httpx-{18,21}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/tests {posargs}
509+
test-instrumentation-httpx: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/tests {posargs}
509510
test-instrumentation-asyncio: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio/tests {posargs}
510511
test-util-http: pytest {toxinidir}/util/opentelemetry-util-http/tests {posargs}
511512
test-sdkextension-aws: pytest {toxinidir}/sdk-extension/opentelemetry-sdk-extension-aws/tests {posargs}
@@ -601,7 +602,7 @@ commands_pre =
601602
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-tornado/test-requirements.txt
602603
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-tortoiseorm[test]
603604
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-mysql[test]
604-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx[test]
605+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/test-requirements-1.txt
605606
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-aws-lambda[test]
606607
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-system-metrics[test]
607608
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio/test-requirements.txt

0 commit comments

Comments
 (0)