Skip to content

Commit e923938

Browse files
authored
Remove [test] package from starlette instrumentation (#2278)
Fixes #2221
1 parent e56cdc8 commit e923938

File tree

3 files changed

+35
-10
lines changed

3 files changed

+35
-10
lines changed

instrumentation/opentelemetry-instrumentation-starlette/pyproject.toml

-6
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@ dependencies = [
3535
instruments = [
3636
"starlette ~= 0.13.0",
3737
]
38-
test = [
39-
"opentelemetry-instrumentation-starlette[instruments]",
40-
"opentelemetry-test-utils == 0.45b0.dev",
41-
"requests ~= 2.23", # needed for testclient
42-
"httpx ~= 0.22", # needed for testclient
43-
]
4438

4539
[project.entry-points.opentelemetry_instrumentor]
4640
starlette = "opentelemetry.instrumentation.starlette:StarletteInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
anyio==4.3.0
2+
asgiref==3.7.2
3+
attrs==23.2.0
4+
certifi==2024.2.2
5+
charset-normalizer==3.3.2
6+
Deprecated==1.2.14
7+
exceptiongroup==1.2.0
8+
h11==0.14.0
9+
httpcore==1.0.4
10+
httpx==0.27.0
11+
idna==3.6
12+
importlib-metadata==6.11.0
13+
iniconfig==2.0.0
14+
packaging==23.2
15+
pluggy==1.4.0
16+
py==1.11.0
17+
py-cpuinfo==9.0.0
18+
pytest==7.1.3
19+
pytest-benchmark==4.0.0
20+
requests==2.31.0
21+
sniffio==1.3.0
22+
starlette==0.13.8
23+
tomli==2.0.1
24+
typing_extensions==4.9.0
25+
urllib3==2.2.1
26+
wrapt==1.16.0
27+
zipp==3.17.0
28+
-e opentelemetry-instrumentation
29+
-e instrumentation/opentelemetry-instrumentation-asgi
30+
-e util/opentelemetry-util-http
31+
-e instrumentation/opentelemetry-instrumentation-starlette

tox.ini

+4-4
Original file line numberDiff line numberDiff line change
@@ -345,8 +345,8 @@ commands_pre =
345345

346346
grpc: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
347347

348-
tornado,starlette,fastapi,aiohttp,httpx-{18,21},requests,urllib,urllib3v-{1,2}: pip install {toxinidir}/util/opentelemetry-util-http
349-
starlette,fastapi: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asgi
348+
tornado,fastapi,aiohttp,httpx-{18,21},requests,urllib,urllib3v-{1,2}: pip install {toxinidir}/util/opentelemetry-util-http
349+
fastapi: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asgi
350350

351351
wsgi: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi/test-requirements.txt
352352

@@ -411,7 +411,7 @@ commands_pre =
411411

412412
requests: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-requests[test]
413413

414-
starlette: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-starlette[test]
414+
starlette: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-starlette/test-requirements.txt
415415

416416
system-metrics: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-system-metrics[test]
417417

@@ -561,7 +561,7 @@ commands_pre =
561561
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-botocore[test]
562562
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-boto3sqs[test]
563563
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-django/test-requirements-3.txt
564-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-starlette[test]
564+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-starlette/test-requirements.txt
565565
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
566566
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon/test-requirements-2.txt
567567
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-boto[test]

0 commit comments

Comments
 (0)