Skip to content

Commit f266fd3

Browse files
jeremydvossocelotl
authored andcommitted
Fix Azure resource detector dependency
1 parent e5aa74f commit f266fd3

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2626
([#2020](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2020))
2727
- `opentelemetry-instrumentation-urllib`/`opentelemetry-instrumentation-urllib3` Fix metric descriptions to match semantic conventions
2828
([#1959](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1959))
29+
- `opentelemetry-resource-detector-azure` Added dependency for Cloud Resource ID attribute
30+
([#2072](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2072))
2931

3032
## Version 1.21.0/0.42b0 (2023-11-01)
3133

resource/opentelemetry-resource-detector-azure/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ classifiers = [
2525
"Programming Language :: Python :: 3.11",
2626
]
2727
dependencies = [
28-
"opentelemetry-sdk ~= 1.19",
28+
"opentelemetry-sdk ~= 1.21",
2929
]
3030

3131
[project.optional-dependencies]

resource/opentelemetry-resource-detector-azure/src/opentelemetry/resource/detector/azure/vm.py

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
ResourceAttributes,
2525
)
2626

27-
# TODO: Remove when cloud resource id is no longer missing in Resource Attributes
2827
_AZURE_VM_METADATA_ENDPOINT = "http://169.254.169.254/metadata/instance/compute?api-version=2021-12-13&format=json"
2928
_AZURE_VM_SCALE_SET_NAME_ATTRIBUTE = "azure.vm.scaleset.name"
3029
_AZURE_VM_SKU_ATTRIBUTE = "azure.vm.sku"

0 commit comments

Comments
 (0)