Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Please add support for mysqlclient connector #1649

Closed
bigon opened this issue Feb 8, 2023 · 2 comments · Fixed by #1744
Closed

Please add support for mysqlclient connector #1649

bigon opened this issue Feb 8, 2023 · 2 comments · Fixed by #1744
Labels
feature-request help wanted Extra attention is needed

Comments

@bigon
Copy link

bigon commented Feb 8, 2023

Hello,

ATM it seems that the mysql instrumentation only support pymysql and mysql-connector-python, but for what I can see SQLAlchemy uses, by default mysqldb (aka mysqlclient)

Shouldn't mysqlclient be added so instrumentation works OOTB?

Note that SQLAlchemy explicitly says that mysql-connector-python is not supported:

    The MySQL Connector/Python DBAPI has had many issues since its release,
    some of which may remain unresolved, and the mysqlconnector dialect is
    **not tested as part of SQLAlchemy's continuous integration**.
    The recommended MySQL dialects are mysqlclient and PyMySQL.
@srikanthccv srikanthccv added the help wanted Extra attention is needed label Feb 10, 2023
@rahuldimri
Copy link
Contributor

We want to try on this. Could you please assign this task to me. Thanks

@Fenkiou
Copy link
Contributor

Fenkiou commented Apr 6, 2023

Hello, I've created a PR to address that issue because I need this at work.

But I realized that I could just use the dbapi instrumentation like this

trace_integration(MySQLdb, "connect", "mysql")

So I am wondering, why do we need dedicated instrumentation librairies if the dbapi one is able to handle those that complies with PEP-0249?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature-request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants