Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

http.server.duration metric description is wrong #2753

Closed
KyriosGN0 opened this issue Jul 30, 2024 · 7 comments · Fixed by #2817
Closed

http.server.duration metric description is wrong #2753

KyriosGN0 opened this issue Jul 30, 2024 · 7 comments · Fixed by #2817
Assignees
Labels
bug Something isn't working

Comments

@KyriosGN0
Copy link

Describe your environment

OS: K8S
Python version: 3.11
Package version: 0.46b0

What happened?

our Otel Collectors are dropping metrics caused due to a description in some metrics not being set correctly, this was fine in 0.45b0, it seems that it was reverted/overridden here
as a result we see the errors like in this issue

Steps to Reproduce

  1. set up otel collectors in k8s
  2. setup fastAPI apps with auto-instrumentation

Expected Result

no errors

Actual Result

metrics being dropped as result of mismatch in description

Additional context

No response

Would you like to implement a fix?

None

@KyriosGN0 KyriosGN0 added the bug Something isn't working label Jul 30, 2024
@StevenPenn
Copy link
Contributor

I'll try to work on this.

@emdneto
Copy link
Member

emdneto commented Aug 6, 2024

@KyriosGN0, are you facing the issue with the new version?

@StevenPenn
Copy link
Contributor

I found the current description of "http.server.duration" and "http.server.request.duration" is not consistent with the "open telemetry.io".
https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/#http-server-duration-metric
So, I'll create a PR soon to fix this issue.

@emdneto
Copy link
Member

emdneto commented Aug 7, 2024

@StevenPenn, We made recent changes in several instrumentations to make them compatible with new semantic conventions, so any suggestion is appreciated.

@StevenPenn
Copy link
Contributor

StevenPenn commented Aug 13, 2024

Hi @emdneto, sorry for the late reply, the PR is still in compliance process.

Currently, I found the "http.server.duration" is updated to "http.server.request.duration" according to the https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/#http-server-duration-metric.

Screenshot 2024-08-13 at 10 07 41

But in our repo, the description of "http.server.duration" and "http.server.request.duration" is mixed.
Such as:

@emdneto
Copy link
Member

emdneto commented Aug 13, 2024

@StevenPenn Thanks, I noticed that. Let me know if you are open to work on this or someone else can take it over

@StevenPenn
Copy link
Contributor

StevenPenn commented Aug 13, 2024

@StevenPenn Thanks, I noticed that. Let me know if you are open to working on this or someone else can take it over

Sure, I am working on it and will create PR as soon as possible. And could you please assign this to me, so someone else can take other issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
3 participants