From 9a217571cb34baf6ea5df252a26b8005b70c9f22 Mon Sep 17 00:00:00 2001 From: jack-berg <34418638+jack-berg@users.noreply.github.com> Date: Wed, 25 Oct 2023 20:33:01 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Trask Stalnaker --- buildscripts/templates/SemanticAttributes.java.j2 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/buildscripts/templates/SemanticAttributes.java.j2 b/buildscripts/templates/SemanticAttributes.java.j2 index d1ceb6c..c4caf84 100644 --- a/buildscripts/templates/SemanticAttributes.java.j2 +++ b/buildscripts/templates/SemanticAttributes.java.j2 @@ -670,7 +670,7 @@ public final class {{class}} { /** * Immediate client peer port number. * - * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_PORT} instead. + * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_PORT} on server telemetry and {@link SemanticAttributes#NETWORK_LOCAL_PORT} on client telemetry instead. */ @Deprecated public static final AttributeKey CLIENT_SOCKET_PORT = longKey("client.socket.port"); @@ -708,7 +708,7 @@ public final class {{class}} { * the socket's peer address, and not attempt to find any actual server IP (i.e., if set from * client, this may represent some proxy server instead of the logical server). * - * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_ADDRESS} instead. + * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_ADDRESS} on server telemetry and {@link SemanticAttributes#NETWORK_PEER_ADDRESS} on client telemetry instead. */ @Deprecated public static final AttributeKey SERVER_SOCKET_ADDRESS = @@ -767,7 +767,7 @@ public final class {{class}} { /** * Physical server port. * - * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_PORT} instead. + * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_PORT} on server telemetry and {@link SemanticAttributes#NETWORK_PEER_PORT} on client telemetry instead. */ @Deprecated public static final AttributeKey SERVER_SOCKET_PORT = longKey("server.socket.port"); @@ -775,7 +775,7 @@ public final class {{class}} { /** * Immediate client peer address - unix domain socket name, IPv4 or IPv6 address. * - * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_ADDRESS} instead. + * @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_ADDRESS} on server telemetry and {@link SemanticAttributes#NETWORK_LOCAL_ADDRESS} on client telemetry instead. */ @Deprecated public static final AttributeKey CLIENT_SOCKET_ADDRESS =