Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add semcov for grpc request and response sizes #28

Closed
anuragagarwal561994 opened this issue Oct 23, 2023 · 4 comments
Closed

Add semcov for grpc request and response sizes #28

anuragagarwal561994 opened this issue Oct 23, 2023 · 4 comments

Comments

@anuragagarwal561994
Copy link

We are trying to add functionality to yield grpc request and response size metrics.

As I can see it is not part of semcov, how can it be added so we can change the opentelemetry-java instrumentation to yield these metrics?

@breedx-splk
Copy link

@anuragagarwal561994
Copy link
Author

Yes this is only the metric we wanted to add as attribute so we can extract that attribute in this metric.

@breedx-splk
Copy link

Gotcha. I don't think this repo yet has any support for autogenerating the metric conventions from the yaml, so this definitely relates to #12.

@jack-berg
Copy link
Member

Closing as duplicate of #12. Keeping #12 instead of this because its more generic, and came first.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants