-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add (linux).process.cgroup attribute #1357
Comments
I'm in favour of this attribute being under the |
Hey @rogercoll, don't you think process will be better option for it? I know it's specific to linux, but process is common for all OS. I think the important namespace here is @mjwolf what do you think? |
I think this would be better under |
I don't have a strong opinion about it, given that we already have OS specific attributes without the OS namespace it might make sense to have a unified approach (without OS). We discussed this naming issue during today's system SIG and we notice that some attributes contain the OS while others don't, I think we should agree on the structure and fix these nuances. #1403 |
This was fixed by #1364 |
Area(s)
area:system
Is your change request related to a problem? Please describe.
The
hostmetrics
receiver is currently reporting theprocess.cgroup
attribute: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/hostmetricsreceiver/internal/scraper/processscraper/metadata.yaml#L49This attribute is really helpful as it can be used to extract containerization information like the K8s pod UID and/or the container ID which the process is running on.
Describe the solution you'd like
Standardize the
process.cgroup
attribute.Describe alternatives you've considered
As
cgroups
being a Linux only technology, would it make sense to add the attribute under thelinux
namespace (e.glinux.process.cgroup
)?Additional context
No response
The text was updated successfully, but these errors were encountered: