make auto_open default to stdin/stdout when path evaluates to False #48

golobor · 2017-09-06T18:24:11Z

No description provided.

- auto_open defaults to stdin/stdout when path evaluates to False. resolved #48 - auto_open defaults to stdin/stdout when the path is "-" - if the stream is optional, it's controlled by the module itself Warning: this might be unstable because not all the usecases were tested!

agalitsyna · 2022-04-08T14:41:32Z

Resolved in b002dbe with some additional improvements, such as default to stdin/stdout when "-" found instead of path.

How about transfer to this nice class, which might further simplify this?

pairtools/pairtools/_fileio.py

Lines 139 to 149 in 254695a

    
           class PipedIO: 
        
               def __init__(self, file_or_path, command, mode='r'): 
        
                   """ 
        
                   An experimental class that reads/writes a file, piping the contents  
        
                   through another process. 
        
                   Parameters 
        
                   ---------- 
        
                   file_or_path : file-like object or str 
        
                       A path to the input/output file or an already opened  
        
                       file-like object.

* Separate cli and lib * pairtools flip fix for unannotated chromosomes, resolving #91 * handle empty chromosomes, resolved #76 * fixed rfrags indexing and first rfrag omission, resolved #73 * resolved or deprecated suggestions in #16 * merge improvements, header merge fixed - resolved merge without arguments: #61 - option to add only the first header in merge, resolved #18 * in merge, added option to concatenate instead of merge sorted inputs, resolving: #23 * merge now checks that columns of inputs are the same * I/O improvements - auto_open defaults to stdin/stdout when path evaluates to False. resolved #48 - auto_open defaults to stdin/stdout when the path is "-" - if the stream is optional, it's controlled by the module itself * Parse2 update (#99) (#109) Improved version of parse2 with resolved comments from the previous PR: #96 - Separation of parse and parse2 modules. Parse has an option --walks-policy all, which parses long walks, but always reporting pair orientation and outer positions of 5'-ends, as if each pair was read in paired-end mode independently. Parse2 is specifically designed for long walks, and has options --report-position and --report-orientation, which might be used to report junctions, or reads, or walks. - Parse2 has an option to parse single-end reads, --single-end option, tested on minimap2 output for MC-3C. - Parse2 has the max_fragment_size instead instead of parse's max_molecule_size, which help to determine the overlapping ends of forward and reverse reads. - Recent update simplifies the code: single _parse library used by both parse and parse2, - a number of functions that reduce repetitive code, e.g. push_pair function, - dosctrings and documented structure of _parse library. - Both parse and parse2 have the options to report 5' or 3' ends; to flip alignments according to chromosome coordinate. - Both parse and parse2 have the pysam backend - Improvements of the tests for parse and parse2 - Documentation includes description of various --report-orientation and --report-position cases. * Merge pairlib into pairtools.lib. * CLI for scalings added. * stats output in yaml format * Header CLI (#121) - new module called by `pairtools header` - submodules: - generate : Generate the header - set-columns : Add the columns to the .pairs/pairsam file - transfer : Transfer the header from one pairs file to another - validate-columns : Validate the columns of the .pairs/pairsam file - resolves #119 - option remove-columns for `pairtools select`: Remove the columns from .pairs/pairsam file * pairtools phase critical update (#114) * imporant fixes: - cython dedup with no-parent id forgotten counter reset; - sphinx doc update (added pysam); - header warning if empty and error if try to add a field to empy one * Add summaries (#105) * Add functions for duplication tile and complexity * Make dedup stats! * Benchmarks finalization * [WIP] Stats split by filters (#132) * Markasdup lib removed; markasdup CLI explanation improved * dedup filter stats added and tested Co-authored-by: Aleksandra Galitsyna <agalitzina@gmail.com> Co-authored-by: Ilya Flyamer <flyamer@gmail.com>

agalitsyna mentioned this issue Apr 6, 2022

pairtools v1.0.0 roadmap #116

Closed

31 tasks

open2c locked and limited conversation to collaborators Apr 20, 2022

agalitsyna converted this issue into discussion #127 Apr 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

This issue was moved to a discussion.

make auto_open default to stdin/stdout when path evaluates to False #48

make auto_open default to stdin/stdout when path evaluates to False #48

golobor commented Sep 6, 2017

agalitsyna commented Apr 8, 2022

This issue was moved to a discussion.

This issue was moved to a discussion.

make auto_open default to stdin/stdout when path evaluates to False #48

make auto_open default to stdin/stdout when path evaluates to False #48

Comments

golobor commented Sep 6, 2017

agalitsyna commented Apr 8, 2022

This issue was moved to a discussion.