Hashing Enhancements for Efficient RoCE Traffic Distribution #2144
+220
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Satheesh Kumar Karra <skarra@marvell.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
requested changes
Feb 27, 2025
| /** No field - for compatibility, must be last */ | ||
| SAI_NATIVE_HASH_FIELD_NONE = 0x00000021, | ||
| SAI_NATIVE_HASH_FIELD_NONE = 0x00000023, |
There was a problem hiding this comment.
this is not backward compatible change and you are adding exception for that, please remove
There was a problem hiding this comment.
Modified this based on comment on Line No:178. This might change in future even with new hash-field additions.
Can we deprecate this enum definition and start adding new fields after this.? will add a comment saying not a valid field used only for backward compatibility
There was a problem hiding this comment.
bring it back to expected value and remove exception in ancestry, NONE is none, no mather what value it has binary
kcudnik
requested changes
Feb 27, 2025
| @@ -178,6 +178,7 @@ sub BuildCommitHistory | |||
| next if $enumName eq "SAI_OBJECT_TYPE_MAX"; | |||
| next if $enumName eq "SAI_PORT_INTERFACE_TYPE_MAX"; | |||
| next if $enumName eq "SAI_PORT_BREAKOUT_MODE_TYPE_MAX"; | |||
| next if $enumName eq "SAI_NATIVE_HASH_FIELD_NONE"; | |||
There was a problem hiding this comment.
adding exception is not backward compatible, please revert
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Feature adds New Hash fields to support hashing based on RDMA fields