Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release v1.2.0-rc.3 #4389

Closed

Conversation

lifubang
Copy link
Member

@lifubang lifubang commented Aug 31, 2024

[1.2.0-rc.3] - 2024-09-02

The supreme happiness of life is the conviction that we are loved.

Added

Fixed

Changed

@lifubang lifubang changed the title Releasenotes v1.2.0 rc.3 Releas v1.2.0 rc.3 Aug 31, 2024
@lifubang lifubang changed the title Releas v1.2.0 rc.3 Releas v1.2.0-rc.3 Aug 31, 2024
@lifubang lifubang force-pushed the releasenotes-v1.2.0-rc.3 branch 2 times, most recently from 45fc0bc to 059916f Compare August 31, 2024 10:42
Signed-off-by: lifubang <lifubang@acmcoder.com>
Signed-off-by: lifubang <lifubang@acmcoder.com>
@lifubang lifubang force-pushed the releasenotes-v1.2.0-rc.3 branch from 059916f to 1c52b46 Compare August 31, 2024 10:44
@AkihiroSuda AkihiroSuda changed the title Releas v1.2.0-rc.3 Release v1.2.0-rc.3 Aug 31, 2024
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'll be afk next week.

@cyphar
Copy link
Member

cyphar commented Aug 31, 2024

We still need to merge the private branch though. I guess I can push it before merging this. (This is why I suggested I do the release this time.)

@lifubang
Copy link
Member Author

lifubang commented Sep 1, 2024

Yes, it’s indeed more convenient to do it by yourself, feel free to close this one.

@cyphar
Copy link
Member

cyphar commented Sep 2, 2024

Since you've already done the changelog (thanks!), I'll just rebase this.

@cyphar
Copy link
Member

cyphar commented Sep 3, 2024

Actually, it's easier to push it manually. I'll cherry-pick your release commits.

@cyphar cyphar closed this Sep 3, 2024
@lifubang lifubang deleted the releasenotes-v1.2.0-rc.3 branch October 15, 2024 05:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants