Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SQLAlchemy Deprecated features #1665

Open
whatnick opened this issue Nov 24, 2024 · 1 comment
Open

SQLAlchemy Deprecated features #1665

whatnick opened this issue Nov 24, 2024 · 1 comment
Assignees

Comments

@whatnick
Copy link
Member

Expected behaviour

Parity with new SQL Alchemy features / deprecations is maintained in the new Index drivers for Postgres/ PostGIS. Perhaps a SQLAlchemy version check if / case statement is applicable for these queries.

Actual behaviour

SQLAlchemy warns of deprecations.

  /env/lib/python3.12/site-packages/datacube/drivers/postgres/_api.py:1107: RemovedIn20Warning: Deprecated API features detected! These feature(s) are not compatible with SQLAlchemy 2.0. To prevent incompatible upgrades prior to updating applications, ensure requirements files are pinned to "sqlalchemy<2.0". Set environment variable SQLALCHEMY_WARN_20=1 to show all deprecation warnings.  Set environment variable SQLALCHEMY_SILENCE_UBER_WARNING=1 to silence this message. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)
    select([

Steps to reproduce the behaviour

Run datacube code with sqlalchemy 1.4.54

Environment information

  • Which datacube --version are you using? - 1.8.19
  • What datacube deployment/enviornment are you running against? - CSIRO EASI

Note: Stale issues will be automatically closed after a period of six months with no activity.
To ensure critical issues are not closed, tag them with the Github pinned tag.
If you are a community member and not a maintainer please escalate this issue to maintainers via
GIS StackExchange or Discord.

@whatnick whatnick self-assigned this Nov 24, 2024
@SpacemanPaul
Copy link
Contributor

1.9 branch is fully SQLAlchemy2 compatible. I think the resolution of this issue is retiring 1.8

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants