Toolkit Showcase examples has NGL errors #1718
Comments
|
I get 3.0.6 pulled down in a fresh environment, which works for me in Jupyter Lab but not conventional notebooks (and seems to be what I was using in a separate environment yesterday without issue). |
|
I've made clean envs from I'm trying to remember the implications of changing |
+1 My top-secret weapon ( $ grep -r "examples/environment.yaml" . 11:31:19 ☁ openmm-simulation ☂ ⚡
./.github/workflows/examples.yml: # If openmmforcefields is included in examples/environment.yamlI can't imagine something externally uses this file, and if that file isn't referenced anywhere it must not show up in relevant documentation. |
|
I re-tried launching using |
|
Hi @tdudgeon, thanks for the report. The issue is that we shouldn't have exposed that We're working on PR #1719 to remove the bad environment file and direct users somewhere more helpful, which will close this issue. In the meantime, could you let me know whether creating a new env from |
|
I would argue that having an I will try using |
Yeah, I agree that having minimal envs for each example would be better, but we'd also need to maintain each one of them, which we can't afford at this time.
We don't communicate this well, but each example on the ecosystem examples page will pull its own environment yaml if users click the "download notebook" link. Right now this is a maximal env for most examples but we have the machinery to support per-example minimal envs if we end up with more time for maintenance on our hands. |
I think it was a way to change example dependencies in CI before a new release, or it was used by Binder. Since we've moved away from Binder we shouldn't need it anymore. It might even be from before
The linked page does include a section describing this - it would be helpful to know how this could be made more clear! |
|
I've confirmed that NGL works fine if using a conda environment based on |
Describe the bug
NGL viewer is not function in toolkit showcase notebook.
Seems that this version of NGL is broken. Need to use an older one?
To Reproduce
Clean checkout from github. Then:
Then open the notebook and start executing the cells.
Output
Run the notebook cells. When running the first one that uses NGLView you get an error and nothing displays. The JS console shows:
Computing environment:
conda list:Additional context
This page does mention steps needed to get NGL working, which have been necessary in the past, but the NGL version is 3.0.6 so this shouldn't be needed AND
jupyter-nbextensionis not present in the conda environment anyway.The text was updated successfully, but these errors were encountered: