Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add ForceField.combine #1996

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add ForceField.combine #1996

wants to merge 4 commits into from

Conversation

mattwthompson
Copy link
Member

Resolves #1948

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (74cfe94) to head (2e39dca).

Additional details and impacted files

@mattwthompson
Copy link
Member Author

Failures appear to be identical to upstream (#1997)

@mattwthompson mattwthompson marked this pull request as ready for review January 16, 2025 22:45
@mattwthompson
Copy link
Member Author

Those type-checker failures are surprising given that that topology.py isn't updated here - can have a look tomorrow if you wish

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine force fields in-memory
2 participants
@mattwthompson @j-wags