Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RDKit from_smiles allows implicit H smiles when explicit H is True #936

Closed
SimonBoothroyd opened this issue May 14, 2021 · 1 comment · Fixed by #1983
Closed

RDKit from_smiles allows implicit H smiles when explicit H is True #936

SimonBoothroyd opened this issue May 14, 2021 · 1 comment · Fixed by #1983

Comments

@SimonBoothroyd
Copy link
Contributor

SimonBoothroyd commented May 14, 2021

Describe the bug

The RDKit toolkit wrapper does not raise the expected exception when creating a molecule from '[NH+:1]([C@:2]([C:3](=[O:4])[O-:10])([C:5]([C:6]([C:7]([C:8]([NH+:9]([H:22])[H:23])([H:20])[H:21])([H:18])[H:19])([H:16])[H:17])([H:14])[H:15])[H:13])([H:11])[H:12]' when the explicit_hydrogens option is set to true.

This allows some of the Season 1 pharmaceutical benchmarking molecules (of which this is an example) to pass through the checks likely incorrectly. The correct exception is raised by OpenEye.

(cc @JoshHorton , @dotsdl , @j-wags )

To Reproduce

Molecule.from_mapped_smiles(
    '[NH+:1]([C@:2]([C:3](=[O:4])[O-:10])([C:5]([C:6]([C:7]([C:8]([NH+:9]([H:22])[H:23])([H:20])[H:21])([H:18])[H:19])([H:16])[H:17])([H:14])[H:15])[H:13])([H:11])[H:12]',
    toolkit_registry=RDKitToolkitWrapper()
)

Output
The full error message (may be large, that's fine. Better to paste too much than too little.)

Computing environment (please complete the following information):

  • Operating system OSX
  • Output of running conda list openff-toolkit ==0.9.2, rdkit ==2021.03.1

Additional context
Add any other context about the problem here.

@j-wags
Copy link
Member

j-wags commented May 14, 2021

Possibly related to #900 -- Looking into this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants