Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove deprecated exceptions #1156

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Remove deprecated exceptions #1156

merged 5 commits into from
Jan 6, 2022

Conversation

mattwthompson
Copy link
Member

In #1021 we added some deprecated exceptions with the plan to remove them in January 2022.

@codecov
Copy link

codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #1156 (1fc741c) into master (1539966) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@openforcefield openforcefield deleted a comment from lgtm-com bot Dec 21, 2021
@openforcefield openforcefield deleted a comment from lgtm-com bot Dec 21, 2021
@openforcefield openforcefield deleted a comment from lgtm-com bot Dec 21, 2021
@mattwthompson mattwthompson marked this pull request as ready for review December 21, 2021 18:01
j-wags
j-wags approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mattwthompson.

@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2022

This pull request fixes 1 alert when merging 1fc741c into 1539966 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@mattwthompson mattwthompson merged commit 12f5e3b into master Jan 6, 2022
@mattwthompson mattwthompson deleted the remove-deprecated-exceptions branch January 6, 2022 17:12
mattwthompson added a commit that referenced this pull request Apr 13, 2022
@mattwthompson
Port #1156
390e7b9 
* Remove deprecated exceptions

* Update release history

* Remove some unused imports

* Fix broken import
mattwthompson added a commit that referenced this pull request Apr 14, 2022
@mattwthompson
Port #1156 (#1266)
d1a10e9 
* Port #1156

* Remove deprecated exceptions

* Update release history

* Remove some unused imports

* Fix broken import

* Fix unused import

* Fix type annotations
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags