-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Possible issue with angle parameter involving five-membered rings #84
Comments
Hi @hjuinj I wanted to post a quick update on what I have found looking into this parameter. I would like to remind you that smirnoff99Frosst is a translation of the parm99/parm@frosst force field into the SMIRNOFF format. That means this is intended to represent an angle parameter taken from that set of parameters. That being said, I this it is possible we had a transcription error because this parameter is assigned to pentane type rings (those with tetrahedral carbons) and pentene/aromtic-ish type rings (those with trivalent carbons). It doesn't make sense to me that these groups would receive the same parameters, so you are probably correct that there is a problem. This parameter would make more sense in the latter group where the extra-cyclic angles should be greater than 120 due to the ring strain. Here are some example angles highlighted by this parameter from the MiniDrugBank set with the corresponding parm99/parm@frosst atom types: Tetrahedral carbonPlanar carbons: |
In this comment I have my excavation into the original parameter files: Atom types in the examples above:Here are the specific parameters for the examples I shared above from
Similar parameters in parm99When those failed I looked for a carbon type specific for 5-membered rings. There are a lot, mostly focused on carbon in aromatic heterocycles. So, my next step is to find the Angles between the oxygen and other neighbors in carbonyl groups:
Pyrimidine carbons (these are 6-membered rings so they don't apply here):
Bridging carbons between 5&6 membered rings (like tryptophan)
The 5-membered ring in purine type groups.
Perhaps this is the parameter we're looking for, this is "aromatic" 5-membered rings with a substituent. aromatic is in quotes since these molecules won't be aromatic in the MDL model.
Similar parameters in parm@Frosst:There are a significant number of parameters added with the parm@frosst extension which include the Addition of more sulfur parameters, I assume these have nothing to do with the ring size:
Specific biphenyl
More 5&6 ring junctions:
Extension of the
"aromatic" 5-membered rings such as histidine:
and
Conclusions:It seems clear this parameter is being assigned too generally. Perhaps there was a mis-ordering that lead to it being placed too far down on the hierarchy. I assume this parameter should only be applied to the last category, or at least only trivalent carbons so make the change from All that being said, I'd like to get @cbayly13's eye's on this logic to see if I'm understanding the reasoning behind this parameter. |
Hi Caitlin, thanks for the swift and thorough investigation. I too would very much like to hear Christopher's take on this. I will just briefly add that I did look at the ordering of this SMIRKS. It has moved from |
I agree with the analysis of @davidlmobley and @bannanc above. The equilibrium angle of ~125 is for external bond angles around an sp2 atom in a 5-membered ring; as @hjuinj noted this angle is wrong for tetrahedral centers in a 5-membered ring. Perhaps a minimal change to the offending parameter could be to introduce a "trivalent" requirement along the lines of |
@cbayly13 I'm happy with using I can put in a pull request in a little bit with the |
Also, I will double check the syntax matches the atoms we expect, but that SMIRKS looks good to me. |
@bannanc if that change fixes only carbons it will be sufficient to address most of the concerns raised by @hjuinj, @davidlmobley and you above. For nitrogens I am still hoping we can address the planarity through the OOP as we discussed a while back (summer?), ie valence angle always wants tetrahedral but OOP forces planarity more or less depending on chemistry, so they "fight" in the case of planar N's. Those hopes don't help us right now with smirnoff99Frosst or whatever we are calling our current development version. Currently perhaps the external N angle needs to look on both sides to see if there is an sp2 center, as in |
Agree we should eventually deal with nitrogens separately. @bannanc can you address? |
Yes, I got a bit distracted away from this yesterday, PRs coming momentarily. |
I'm closing this since we fixed it in PR #85 |
Hi @bannanc, a colleague of mine has noticed a particular pattern seemed to be causing strains in some systems he was looking at.
The SMIRKS in questions is
<Angle smirks="[*:1]~;!@[*;r5:2]~;@[*;r5:3]" angle="125." id="a14" k="140.0"/>
in the latest smirnoff99Frosst.offxml. He shared with me calculations fromcccbdb.nist.gov
, for example in the image I show dft with cc-pVTZ calculation of cyclopentane which has the relevant angles at equilibrium values of ~109 degrees rather than 125 (similar angles when using other method and basis sets). Is it possible that there might be an issue with this parameter?The text was updated successfully, but these errors were encountered: