Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

♻️ refacto needed on all converse plugins #1466

Open
roro-lv opened this issue Mar 31, 2022 · 0 comments
Open

♻️ refacto needed on all converse plugins #1466

roro-lv opened this issue Mar 31, 2022 · 0 comments
Labels

Comments

@roro-lv
Copy link
Contributor

roro-lv commented Mar 31, 2022

The code in converse plugins (utils/conversejs/converse-plugins/...) lacks of clarity and is a bit confused. It need to be refactored.
Here are some suggestion to start :

  • stanzas are typed with HTLMElement, which works, but which isn't reflecting the reallity of it. Indeed, stanza are xml-written and have nothing to do with HTML. It should be changed to use correct typing.
  • stanzas are processed with functions as getElementsByTagName or getAttribute. A proper xml lib should be installed to easily parse stanzas.
  • Some comments could be adeed, at least to explain what stanzas are supposed to contain
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant