Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Warn users if their geojson is not in iso_country #34

Open
cholmes opened this issue Oct 9, 2023 · 0 comments
Open

Warn users if their geojson is not in iso_country #34

cholmes opened this issue Oct 9, 2023 · 0 comments
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers

Comments

@cholmes
Copy link
Collaborator

cholmes commented Oct 9, 2023

Adding a wrong iso_country will result in 0 buildings coming down, since it'll just query the wrong country. It'd be good to warn users about that possibility.

I think this can be pretty simple - just check if there are 0 features that are downloaded and if the user provided a country_iso. If both of those are true then print out something like 'WARNING: You supplied country_iso BR and your geojson got 0 buildings. Check to be sure your GeoJSON is actually in the right country'. Note that if we do #29 then there will hopefully be no need for this warning.

@cholmes cholmes added enhancement New feature or request good first issue Good for newcomers get_buildings Issues related to the get_buildings operations labels Oct 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant