Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

prometheus 不能正常采集 hystrix 线程池 queue.capacity 数据 #1129

Closed
jjiey opened this issue Mar 20, 2023 · 2 comments · Fixed by #1130
Closed

prometheus 不能正常采集 hystrix 线程池 queue.capacity 数据 #1129

jjiey opened this issue Mar 20, 2023 · 2 comments · Fixed by #1130
Assignees
@jjiey
Labels
type: bug Something isn't working
Milestone
1.5.0

Comments

@jjiey
Copy link
Contributor

jjiey commented Mar 20, 2023 •
edited
Loading

BUG 报告

在开始报告错误之前，请确保认真查看了以下步骤：

请在提交问题之前回答这些问题，谢谢。

你使用了哪个项目？hippo4j config 还是 hippo4j server?

hippo4j config

你使用了哪个版本？

最新版本

预期行为

prometheus 正常采集 hystrix 线程池数据

实际行为

prometheus 采集 hystrix 线程池数据报 warn（NPE）:
Failed to apply the value function for the gauge 'adapter.thread-pool.queue.capacity'. Note that subsequent logs will be logged at debug level.

原因分析（如果可以）

HystrixThreadPoolAdapter#getThreadPoolState 中没有 setBlockingQueueCapacity 导致

问题重现步骤

用于重现此问题的示例代码（例如 GitHub 链接）
@jjiey
Copy link
Contributor Author

jjiey commented Mar 20, 2023 •
edited
Loading

assign me pls

@magestacks magestacks added the type: bug Something isn't working label Mar 20, 2023
@magestacks magestacks added this to the 1.5.0 milestone Mar 20, 2023
@magestacks
Copy link
Member

@jjiey welcome

@jjiey jjiey mentioned this issue Mar 20, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jjiey jjiey

Labels
type: bug Something isn't working
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

fix 1129: AbstractHystrixThreadPoolAdapter set BlockingQueueCapacity jjiey/hippo4j
2 participants
@jjiey @magestacks