From 6dc07385f01bab245348c91a49db3b7a6787abb2 Mon Sep 17 00:00:00 2001 From: Florian Hotze Date: Wed, 8 Jan 2025 18:33:02 +0100 Subject: [PATCH] Chart page: Fix wrong height inside popups, popovers & sheets on iOS (#2991) Fixes known limitation from #2717. Reported on the community: https://community.openhab.org/t/openhab-4-3-release-discussion/160888/155?u=florian-h05 Signed-off-by: Florian Hotze (cherry picked from commit 7034ad9a0a7dd3e017d68243705955f37ac1c4ef) --- .../web/src/components/widgets/chart/oh-chart-page.vue | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bundles/org.openhab.ui/web/src/components/widgets/chart/oh-chart-page.vue b/bundles/org.openhab.ui/web/src/components/widgets/chart/oh-chart-page.vue index 8413ca860e..cf51ae3477 100644 --- a/bundles/org.openhab.ui/web/src/components/widgets/chart/oh-chart-page.vue +++ b/bundles/org.openhab.ui/web/src/components/widgets/chart/oh-chart-page.vue @@ -25,6 +25,9 @@ .device-ios /* fix chart rendering issues on iOS >= 17.4 */ .oh-chart-page-chart --oh-chart-page-height calc(100dvh - var(--f7-safe-area-top) - var(--f7-safe-area-bottom) - var(--f7-navbar-height)) /* use dvh because with % the height is calculated to 0px and ECharts fails to render */ + .popup, .popover, .sheet-modal-inner /* do not apply the above fix inside popups, popovers and sheets */ + .oh-chart-page-chart + --oh-chart-page-height calc(100% - var(--f7-safe-area-top) - var(--f7-safe-area-bottom) - var(--f7-navbar-height))