Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

configurable HTML title for pages #3054

Open
mstormi opened this issue Feb 5, 2025 · 5 comments · May be fixed by #3058
Open

configurable HTML title for pages #3054

mstormi opened this issue Feb 5, 2025 · 5 comments · May be fixed by #3058
Labels
enhancement New feature or request main ui Main UI

Comments

@mstormi
Copy link

mstormi commented Feb 5, 2025

I’d like to be able to define the HTML page title that the openHAB dashboard appears with in browser tabs.
(for now, it's always a static string "openhab").

The default should be changed to use the page’s label, but please also offer an option to override it on all pages, especially on system-generated pages like and including the main dashboard page.

Related: #3037

@mstormi mstormi added enhancement New feature or request main ui Main UI labels Feb 5, 2025
@jimtng
Copy link
Contributor

jimtng commented Feb 6, 2025

but please also offer an option to override it on all pages, especially on system-generated pages like and including the main dashboard page.

I can understand the need to have a different text for normal pages, because the page label is used on the left menu.

However, with the "Overview" page, is the label used in any way that would neccesitate having a separate label for the browser title?

Also, do we want separate title for overview / locations / equipment / properties? At the moment they're actually just one page with tabs, so right now it's just the same browser title when going to those different tabs.

@jimtng
Copy link
Contributor

jimtng commented Feb 6, 2025

@florian-h05 I'm working on this feature at the moment, but I'd like your opinion / input on whether we want to add a browserTitle page setting, like pictured here:

Image

I feel like it's making the page setting section even more complex, and I haven't figured out a nice way to "hide" it (e.g. Advanced settings?) to make the default simpler.

We should probably move this section down the bottom of the page, (when not in create mode) just like how it's done for rules settings, where there's a caret icon to reveal it. That would clear more space for editing the page.

Even if we were add this, it would fall back to page's label if browserTitle isn't specified.

@jimtng jimtng linked a pull request Feb 7, 2025 that will close this issue
@mstormi
Copy link
Author

mstormi commented Feb 7, 2025

However, with the "Overview" page, is the label used in any way that would neccesitate having a separate label for the browser title?

Stand still for a moment and switch point of view. Think of yourself sitting in front of your browser with many tabs open like a NASDAQ chart, a news ticker page and more, most totally unrelated to home automation and openHAB.
A tab called 'overview' would just add to more confusion here. Overview of what? My stock's performance? State of the nation?
And think what if I have multiple openHAB instances, which one it is?
This is where I want the title to read "mstormis home" or whatever I (and not anybody else like e.g. some developer) want it to be at that time. Changeable by myself without restraints, for all pages.
Defaulting to whatever is already shown today is fine, but I must be able to override every single one of them.

@jimtng
Copy link
Contributor

jimtng commented Feb 7, 2025

It seems that I haven't explained it properly.

With this PR, you can set the browser title, by changing the config.label property.

Image

You can set it to whatever you like. It will not be fixed to "Overview".

What I was saying was that there's no need to have a second option called browserTitle for the overview page specifically because its label is not used elsewhere anyway.

This is different to the other pages where their label is used for the openhab's own left sidebar menu, so by adding browserTitle, you can (optionally) set the browser title different to the label, but when it's not set, the browser title will use the label.

@jimtng
Copy link
Contributor

jimtng commented Feb 7, 2025

I feel like it's making the page setting section even more complex, and I haven't figured out a nice way to "hide" it (e.g. Advanced settings?) to make the default simpler.

We should probably move this section down the bottom of the page, (when not in create mode) just like how it's done for rules settings, where there's a caret icon to reveal it. That would clear more space for editing the page.

I have submitted #3056 to address this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants